Differential D25787

Remove unused PhabricatorApplicationTransactionCommentView::getStatusID()
ClosedPublic
Actions

Authored by aklapper on Aug 16 2024, 07:11.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID()

Summary

Calls to this private function were removed in https://we.phorge.it/rPeded19a5c6d3e5fa4e0d655bc8271d2a5baa5a34.

Test Plan

Grep the code; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

unusedMethods4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1537
Build 1537: arc lint + arc unit

Event Timeline

aklapper created this revision.Aug 16 2024, 07:11

Owners added a reviewer: O1: Blessed Committers.Aug 16 2024, 07:11

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2024, 07:11

Harbormaster completed remote builds in B1537: Diff 2382.Aug 16 2024, 07:11

aklapper requested review of this revision.Aug 16 2024, 07:11

sgtm

This revision is now accepted and ready to land.Jan 12 2025, 14:33

Closed by commit rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(). · Explain WhyJan 15 2025, 13:40

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

8 lines

O1: Blessed Committers

Diff 2382

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Remove unused PhabricatorApplicationTransactionCommentView::getStatusID()ClosedPublicActions