or am I supposed to $result = id(new ArcanistHardpointFutureList())->newFromFutures($result);? Yeez

Test plan needed. But I don't know what an "hardpoint" is.

✅ Your static call is right since newFromFutures() is a static method.

https://we.phorge.it/source/arcanist/browse/master/src/hardpoint/ArcanistHardpointFutureList.php$9

🔶 But it's designed to accept an array of futures, not a single one. Maybe just wrap in array($result).

P.S. a final class just means that other classes cannot extend that.

Until now, probably a new object was created but without "futures". So any future was just discarded when entering there. Since PHP probably has (had?) a default constructor that just constructs, discarding arguments in an implicit way.

What will happen now: Future will be kept. But still, no test plan.

I don't know what an "hardpoint" is.

Evan explained it to me once and did reference https://en.wikipedia.org/wiki/Hardpoint. The only relevant thing I could locate is https://secure.phabricator.com/D21716. As I understood it, a hardpoint is a "template" for something that needs to be populated. I believe this pattern exists to enable efficient queries, e.g. build a list of "hardpoints" that describe what's needed, then pass to some sort of locator/executor/query-system to then assemble efficient queries, which could be queries to a database or running git/hg commands to get data.

So this patch which changes (and hopefully also fixes) definitely broken code will be blocked for good due to lack of a test plan (which I won't be able to figure out)?
Or does anyone can come up with any other option?

In general the reporter should really find a small way to reproduce their problem, also because among all the things written here (https://we.phorge.it/book/contrib/article/bug_reports/), everybody may agree with the first point:

We can NOT help you with issues we can not reproduce

https://we.phorge.it/book/contrib/article/reproduction_steps/

As much as I have proactively tried, I'm sorry I have failed to reproduce.

Anyway... working again in a clean empty room without ways to reproduce...

Basically, premising that the constructor of newFromFutures() seems legit, it's not clear to me why its return result should make sense and be compatible with the expected one. If somebody can clarify this, maybe it's at least something more.

Basically, premising that the constructor of newFromFutures() seems legit, it's not clear to me why its return result should make sense and be compatible with the expected one. If somebody can clarify this, maybe it's at least something more.

I'm afraid I cannot offer more clarification than the second sentence in the commit message, as in "what else could this code be supposed to do". :-/