Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php
ClosedPublic

Authored by aklapper on May 15 2024, 12:33.
Tags
None
Referenced Files
F3853240: D25639.1746148408.diff
Thu, May 1, 01:13
F3852579: D25639.1746126663.diff
Wed, Apr 30, 19:11
F3850492: D25639.1746113769.diff
Wed, Apr 30, 15:36
F3847328: D25639.1746106821.diff
Wed, Apr 30, 13:40
F3825921: D25639.1746030829.diff
Tue, Apr 29, 16:33
F3689816: D25639.1745590984.diff
Thu, Apr 24, 14:23
F3648140: D25639.1745416807.diff
Tue, Apr 22, 14:00
F3604600: D25639.1745214717.diff
Sun, Apr 20, 05:51

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/controller/PhabricatorAuthStartController.php:34]

Closes T15832

Test Plan

Run arc unit locally, probably also don't be logged in.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable