Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PhabricatorAuthStartController.php
ClosedPublic

Authored by aklapper on May 15 2024, 12:33.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 8, 15:48
Unknown Object (File)
Sat, Jun 8, 10:07
Unknown Object (File)
Thu, Jun 6, 05:47
Unknown Object (File)
Wed, Jun 5, 23:41
Unknown Object (File)
Thu, May 23, 05:32
Unknown Object (File)
Thu, May 23, 00:15
Unknown Object (File)
Thu, May 23, 00:03
Unknown Object (File)
Wed, May 22, 23:45

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/controller/PhabricatorAuthStartController.php:34]

Closes T15832

Test Plan

Run arc unit locally, probably also don't be logged in.

Diff Detail

Repository
rP Phorge
Branch
strlenAuthSessionToken (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1260
Build 1260: arc lint + arc unit