Looks like this is all that's needed?
Ref T15751
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15751: Make Libphutil and Linters support modern PHP syntax
- Commits
- rARCf6261dc614a7: Arc liberate: support traits
R12 has some scenarios for testing this.
Also ran arc liberate --clean on arc and phorge repos, and the generated map did not change.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- trait
- Lint
Lint Warnings Severity Location Code Message Warning src/symbols/PhutilSymbolLoader.php:401 XHP9 Naming Conventions - Unit
Tests Passed - Build Status
Buildable 1094 Build 1094: arc lint + arc unit
Event Timeline
| support/lib/extract-symbols.php | ||
|---|---|---|
| 265 | Maybe this unset is not that needed | |
Comment Actions
Thanks. Premising I have only knowledge of traits, but not mapbuilder.
- The test plan mentions arc lint --clean. Maybe was arc liberate --clean (?) since the first one does not work for me. The second one works 👍
- Maybe off-topic but that readme (https://we.phorge.it/diffusion/12/browse/master/libph-trait/) mentions a arc test-traits but I'm not able to have that command working. I get Unknown command.
- Just that inline comment :)
Approving since I confirm arc anoid still works after this change
Comment Actions
- (Yes, arc liberate --clean. I'll also run it in Phorge).
- I'll check it again, I refactored some things and maybe I broke that.
| support/lib/extract-symbols.php | ||
|---|---|---|
| 265 | Maybe not, but this is actually a very long script, and not a method, so I figured it would be safer to delete the variable instead of leaking it out for later. I'll try to just extract a method out of this, that would be even safer... | |