Page MenuHomePhorge

Make "git cat-file" exception messages include repository monogram/slug
ClosedPublic

Authored by aklapper on Nov 9 2023, 19:24.

Details

Summary

When throwing an exception related to output provided by git cat-file, include the repository monogram to allow potentially debugging in Git.

Closes T15661

Test Plan

Unclear. Basically: "have a broken Git repository in Diffusion".
(However this patch changes a message only shown in case of an exception, so in the worst case we'd break the exception via an exception.)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.Nov 9 2023, 19:24

If this is considered too dangerous to merge, I could first test this in downstream for a while.

speck subscribed.

This seems reasonable to me. It only adds further information to logs. I suppose there are some paths that could result in showing exception on the client-side but including monogram doesn’t seem concerning/dangerous.

This revision is now accepted and ready to land.Nov 10 2023, 03:58