When throwing an exception related to output provided by git cat-file, include the repository monogram to allow potentially debugging in Git.
Closes T15661
Details
Details
- Reviewers
speck - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15661: Make "git cat-file" exception messages include repository monogram/slug
- Commits
- rP87e9c936ad1c: Make "git cat-file" exception messages include repository monogram/slug
Unclear. Basically: "have a broken Git repository in Diffusion".
(However this patch changes a message only shown in case of an exception, so in the worst case we'd break the exception via an exception.)
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15661GitCatFileDebug (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 899 Build 899: arc lint + arc unit
Event Timeline
Comment Actions
If this is considered too dangerous to merge, I could first test this in downstream for a while.
Comment Actions
This seems reasonable to me. It only adds further information to logs. I suppose there are some paths that could result in showing exception on the client-side but including monogram doesn’t seem concerning/dangerous.