Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation
ClosedPublic

Authored by aklapper on Nov 2 2023, 14:19.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:348]

Closes T15658

Test Plan

Create an empty new Git repository, go to its URIs management page.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.Nov 2 2023, 14:19
aklapper retitled this revision from Fix PHP 8.1 "strlen(null)" exception[s] which block rendering the XXXX page to Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation.Nov 2 2023, 14:20
This revision is now accepted and ready to land.Nov 4 2023, 15:00