Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation
ClosedPublic
Actions

Authored by aklapper on Nov 2 2023, 14:19.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15658: PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation

Commits

rP222a6fea0a1d: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:348]

Closes T15658

Test Plan

Create an empty new Git repository, go to its URIs management page.

Diff Detail

Repository

rP Phorge

Branch

diffEmptyRepoURI (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 877
Build 877: arc lint + arc unit

Event Timeline

aklapper created this revision.Nov 2 2023, 14:19

Owners added a reviewer: O1: Blessed Committers.Nov 2 2023, 14:19

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 2 2023, 14:19

Harbormaster completed remote builds in B877: Diff 1434.Nov 2 2023, 14:19

aklapper requested review of this revision.Nov 2 2023, 14:19

aklapper retitled this revision from Fix PHP 8.1 "strlen(null)" exception[s] which block rendering the XXXX page to Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation.Nov 2 2023, 14:20

speck accepted this revision.Nov 4 2023, 15:00

This revision is now accepted and ready to land.Nov 4 2023, 15:00

Closed by commit rP222a6fea0a1d: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo…. · Explain WhyNov 4 2023, 18:35

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP222a6fea0a1d: Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo….