Page MenuHomePhorge
Differential D25360

Teach Commit View about Encoding
ClosedPublic
Actions

Authored by avivey on Jul 26 2023, 17:55.
Tags
None
Referenced Files
F2197240: D25360.1716242114.diff
Sun, May 19, 21:55
Unknown Object (File)
Sun, May 12, 22:22
Unknown Object (File)
Fri, May 10, 00:14
Unknown Object (File)
Fri, May 10, 00:14
Unknown Object (File)
Wed, May 8, 07:58
Unknown Object (File)
Wed, May 8, 07:32
Unknown Object (File)
Mon, Apr 29, 05:34
Unknown Object (File)
Tue, Apr 23, 01:18
View All Files
Subscribers
Cigaryno
Matthew
speck
tinloaf
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP69c64c1e83e2: Teach Commit View about Encoding
Summary

If the user specifies a text encoding via the "View Options" dropdown, respect this choice.
Ref Q68.

Test Plan

Play with the Encoding button in the view

Diff Detail

Repository
rP Phorge
Branch
more-php8
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 694
Build 694: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 26 2023, 17:55
avivey held this revision as a draft.
Owners added a reviewer: O1: Blessed Committers.Jul 26 2023, 17:55
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 26 2023, 17:55
Harbormaster completed remote builds in B694: Diff 1162.Jul 26 2023, 17:55
avivey mentioned this in Q68: Diffusion refuses to show a commit in a non-UTF-8 file (Answer 91).Jul 26 2023, 17:56
tinloaf subscribed.Aug 4 2023, 15:09

Just a note from my side: I just applied this patch to our Phorge installation and it does exactly what we need. :)

avivey published this revision for review.Aug 26 2023, 07:46
avivey retitled this revision from teach commit view about encoding to Teach Commit View about Encoding.
avivey edited the test plan for this revision. (Show Details)
valerio.bozzolan accepted this revision.EditedAug 26 2023, 10:00

Interestingly I tried to open a simple README file and selecting UTF-8.

It said this nonsense message:

This document was converted from UTF-8 to UTF8 for display.

Is this a relevant corner case?

BTW apart from that, this seems very nice, thanks!

This revision is now accepted and ready to land.Aug 26 2023, 10:00
Closed by commit rP69c64c1e83e2: Teach Commit View about Encoding. · Explain WhyAug 31 2023, 18:00
This revision was automatically updated to reflect the committed changes.
avivey added a commit: rP69c64c1e83e2: Teach Commit View about Encoding.
avivey mentioned this in Next Up.Sep 4 2023, 16:57
avivey mentioned this in 2023 week 49.Dec 8 2023, 17:36

Revision Contents
Changeset List

PathSizePackages
src/
applications/
diffusion/
conduit/
9 linesO1: Blessed Committers
controller/
1 lineO1: Blessed Committers

Diff 1162

View Options

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0