Page MenuHomePhorge

Fix PHP 8.1 substr(null) in People > Activity Logs
ClosedPublic

Authored by Sten on Jul 17 2023, 12:05.

Details

Summary

When someone tries to log on with invalid credentials, a record is inserted in the phabricator_user.user_log table with action = login-fail.
The session value of this record is set to null in this case.

When you open the People → Activity Logs screen, you will see an exception because of this.

Fixes T15555

Test Plan

Go to https://my.phorge.site/people/logs/ after a login failure and a login success.

Diff Detail

Repository
rP Phorge
Branch
activityLogs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 674
Build 674: arc lint + arc unit