Page MenuHomePhorge
Differential D25351

Fix PHP 8.1 substr(null) in People > Activity Logs
ClosedPublic
Actions

Authored by Sten on Jul 17 2023, 12:05.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 12:03
Unknown Object (File)
Wed, Jun 12, 10:32
Unknown Object (File)
Wed, Jun 12, 06:16
Unknown Object (File)
Sun, Jun 9, 16:23
Unknown Object (File)
Sat, Jun 8, 17:11
Unknown Object (File)
Mon, May 27, 17:57
Unknown Object (File)
Sat, May 25, 03:14
Unknown Object (File)
Wed, May 15, 20:45
View All 68 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15555: PHP 8.2: "substr(null) exception" in People > Activity Logs
Commits
rPdbc101ca8ae1: Fix PHP 8.1 substr(null) in People > Activity Logs
Summary

When someone tries to log on with invalid credentials, a record is inserted in the phabricator_user.user_log table with action = login-fail.
The session value of this record is set to null in this case.

When you open the People → Activity Logs screen, you will see an exception because of this.

Fixes T15555

Test Plan

Go to https://my.phorge.site/people/logs/ after a login failure and a login success.

Diff Detail

Repository
rP Phorge
Branch
activityLogs (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 674
Build 674: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
src/
applications/
people/
view/
2 linesO1: Blessed Committers

Diff 1132

View Options

src/applications/people/view/PhabricatorUserLogView.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0