Page MenuHomePhorge

Add resources/ssl/custom.pem to .gitignore
ClosedPublic

Authored by Sten on Jun 19 2023, 10:59.

Details

Summary

When arcanist connects to a phorge site which uses an SSL certificate signed by a local CA, then the client needs to have a resources/ssl/custom.pem file as per resources/ssl/README

As this is client specific it should be in the .gitignore file.

Also update resources/ssl/README to replace [Pp]habricator with [Pp]horge.

Test Plan
touch resources/ssl/custom.pem
git status

The 'git status' should show no changes.

Diff Detail

Repository
rARC Arcanist
Branch
gitignore (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 580
Build 580: arc lint + arc unit

Event Timeline

Sten requested review of this revision.Jun 19 2023, 10:59

Thanks :)

This seems very legit to me. As additional context, in my local installation I have not that file:

tree resources/ssl/
resources/ssl/
├── default.pem
├── default.pem.rej
└── README

0 directories, 3 files

Tested locally. No nuclear implosions :D

lgtm

This revision is now accepted and ready to land.Jun 19 2023, 11:43
resources/ssl/README
39

I wonder if the example should mention path/to/arcanist/resources/ssl/custom.pem

Agreed. The more often we specify the path, the more likely the reader will remember it.

Agreed. The more often we specify the path, the more likely the reader will remember it.
Downside is we need to lose the path/to/ in order to keep lint happy.

Sten marked an inline comment as done.Jun 19 2023, 14:09

Hi @Sten also here feel free to

arc patch D25304

arc land

Or feel free to say: "naah, land that for me 😎"

Wanted to ensure you had a chance to check the changes I made based on your review first...

In D25304#8910, @Sten wrote:

Wanted to ensure you had a chance to check the changes I made based on your review first...

Yep you have been very kind, thanks again!