Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception calling Conduit's user.whoami
ClosedPublic

Authored by aklapper on Jun 13 2023, 00:26.
Tags
None
Referenced Files
F3338197: D25292.1743600352.diff
Tue, Apr 1, 13:25
F3330740: D25292.1743493299.diff
Mon, Mar 31, 07:41
F3329433: D25292.1743475077.diff
Mon, Mar 31, 02:37
F3328311: D25292.1743453998.diff
Sun, Mar 30, 20:46
F3328027: D25292.1743448628.diff
Sun, Mar 30, 19:17
F3321393: D25292.1743352743.diff
Sat, Mar 29, 16:39
F3317379: D25292.1743260729.diff
Fri, Mar 28, 15:05
F3307509: D25292.1743147810.diff
Thu, Mar 27, 07:43

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=master, ref.master=7bbd657c19c4)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/conduit/controller/PhabricatorConduitAPIController.php:686]

Closes T15469

Test Plan

After applying this change, /api/user.whoami correctly renders the "Method Call Result"

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable