Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout
ClosedPublic

Authored by aklapper on May 10 2023, 18:32.
Tags
None
Referenced Files
F2147328: D25217.diff
Thu, Apr 18, 18:38
Unknown Object (File)
Thu, Apr 11, 06:24
Unknown Object (File)
Thu, Apr 11, 05:30
Unknown Object (File)
Wed, Apr 10, 22:06
Unknown Object (File)
Wed, Apr 10, 21:08
Unknown Object (File)
Mon, Apr 8, 04:13
Unknown Object (File)
Sun, Mar 31, 03:09
Unknown Object (File)
Sat, Mar 30, 13:39

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15384

Test Plan

Applied these four changes; logged in again; logged out again; finally saw "Log In" page with "Username or Email" and "Password" field on /auth/loggedout/ rendered in web browser.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable