Differential D25178
Handle ERR-INVALID-AUTH responses from Conduit in patch workflow Authored by chrisnovakovic on May 2 2023, 20:46. Tags None Referenced Files
Details
Conduit responds to requests with either ERR-INVALID-SESSION or ERR-INVALID-AUTH if the request wasn't sufficiently authenticated. Arcanist's patch workflow can automatically attempt to recover from situations in which Conduit responds to unauthenticated requests with ERR-INVALID-SESSION (by resending an authenticated version of the request), but not ERR-INVALID-AUTH - recover from ERR-INVALID-AUTH in the same way. Closes T15333 The company I work for has been running a local clone of Arcanist containing this change in production for over 18 months now with no problems.
Diff Detail
Event TimelineComment Actions Thanks for the patch and welcome in the Phorge patch waiting room While waiting for a reviewer, feel free to enjoy and sign L1 Phorge Vision Statement Comment Actions I approve this patch since a very similar thing was applied by Evan in 2014 in a nearby file and so it seems legit to me: https://we.phorge.it/rARC511898775788a51ef54cc610625375b6249266c5 This patch still need the approval of another person from O1: Blessed Committers. In the meanwhile feel free to open a Task for this in Arcanist, and assign that Task to this review. Thanks Comment Actions All done - there's more detail about why this arises and reproduction steps in T15333. Comment Actions I didn't actually ask for anything 😎 We are the Phorge. If you sign L1 you will be assimilated. Resistance is futile. |