Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Diffusion page
ClosedPublic

Authored by aklapper on Apr 30 2023, 08:08.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 12:45
Unknown Object (File)
Tue, Mar 26, 11:33
Unknown Object (File)
Thu, Mar 14, 23:05
Unknown Object (File)
Fri, Mar 8, 09:00
Unknown Object (File)
Feb 25 2024, 07:35
Unknown Object (File)
Feb 25 2024, 07:35
Unknown Object (File)
Feb 25 2024, 06:53
Unknown Object (File)
Feb 25 2024, 06:47

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15300

Test Plan

Applied these three changes (on top of D25144, D25145, D25146, D25147) and /diffusion/ finally rendered in web browser.

Diff Detail

Repository
rP Phorge
Branch
D25150 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 296
Build 296: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 30 2023, 08:10