Paths

Table of Contentst

Differential D25138

Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make CSS/JS load
ClosedPublic
Actions

Authored by aklapper on Apr 27 2023, 08:10.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15283: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make CSS/JS load

Commits

rPf3b37413167e: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make…

Summary

On a fresh installation with PHP 8.1, CSS does not load on the account creation page.

Closes T15283

Test Plan

After applying this change (and D25137), the account creation page is rendered correctly. See the screenshot in T15283

Diff Detail

Repository

Branch

T15283 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 275
Build 275: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 27 2023, 08:10

Owners added a reviewer: O1: Blessed Committers.Apr 27 2023, 08:10

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 27 2023, 08:10

aklapper requested review of this revision.Apr 27 2023, 08:10

Harbormaster completed remote builds in B275: Diff 535.Apr 27 2023, 08:10

I honestly was not able to reproduce in PHP 8.1 for unknown reasons. I tried enabling registration and registering an account, and I tried also from the internal people menu.

Maybe my computer always sends the HTTP-Range (?) Don't know.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Range

Anyway,

sgtm

src/applications/celerity/controller/CelerityResourceController.php
116	✅ the default of `getHTTPHeader()` is null (and not false or whatever) so `phutil_nonempty_string` should receive a correct input domain of `string` and `null`. ./src/aphront/AphrontRequest.php public static function getHTTPHeader($name, $default = null, $data = null)

This revision is now accepted and ready to land.Apr 27 2023, 08:33

Closed by commit rPf3b37413167e: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make…. · Explain WhyApr 27 2023, 08:51

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPf3b37413167e: Fix PHP 8.1 "strlen(null)" exception inCelerityResourceController to make….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

celerity/

controller/

CelerityResourceController.php

2 lines

O1: Blessed Committers

Diff 535

src/applications/celerity/controller/CelerityResourceController.php

Loading...