Page MenuHomePhorge

Phriction: clarify its search results as "Wiki page"
ClosedPublic

Authored by valerio.bozzolan on Mar 28 2023, 23:00.

Details

Summary

This patch changes a bit how your search results from Phriction
are described in the autocomplete component (the "Typehead"):

Search results including Phriction page - after D25102.png (211×475 px, 16 KB)

After this change, Phriction search results will also contain the word
"Wiki page" so that users can better understand what the result
actually is. Just like a Diffusion repository mentions that it's
a "Repository", and just like a Project mentions that it's a
"Project" and so on.

Before this change, the Typehead entries were only mentioning
the slug of that wiki page.

BeforeAfter
Phorge Wiki Page result before.png (216×422 px, 8 KB)
Mockup Phriction.png (191×405 px, 10 KB)

It's unclear if the previous behavior was a mistake (since the
internal parameter of the Typehead is called "type", and so, it
is supposed to mention the application type, not the slug.

Anyway, as a compromise, the slug is still mentioned.

To be honest this is just an excuse to put the middle dot /
aka interpunct character in this project again. Yeah, here the
middle point was used as separator. The apparent reason is:
because the middle point was already in use elsewhere in Phorge.
The real reason is: I'm a lobbyist in a corporation that sells
interpuncts worldwide as our core business, and so, I designed
thisvil plan to put the following middle point - again - in
Phorge (evil laugh).

Closes T15213

Test Plan
  • Search "Change Log" in the up-right bar (or similar)
  • You see "Wiki Page · change_log/" (or similar)

Diff Detail

Repository
rP Phorge
Branch
T15213_phriction_search_result
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 202
Build 202: arc lint + arc unit

Unit TestsFailed

TimeTest
759 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
959 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
1,274 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
266 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
1 assertion passed.
298 msPhabricatorLibraryTestCase::testEverythingImplemented
1 assertion passed.
View Full Test Results (1 Failed · 6 Passed)

Event Timeline

add celerity (so to fix older revisions)

can you show a screenshot with and without this change?

In D25102#3155, @avivey wrote:

can you show a screenshot with and without this change?

Sure!

Before:

Phorge Wiki Page result before.png (216×422 px, 8 KB)


After:

Mockup Phriction.png (191×405 px, 10 KB)

Before:

This shows the slug.

After:

This shows the type and the slug (kind of compromise).

Future:

Maybe we can drop the slug since in my opinion is just a repetition of the title in most cases and it's not that useful. But I'm not bold enough to do it now.

This revision is now accepted and ready to land.Apr 5 2023, 12:05