Paths

Table of Contentst

Differential D25071

Modernize codebase to features available since PHP 5.5
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 6 2023, 07:48.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15158: "Modernize" codebase to features available since PHP 5.5 (that is the actual announced minimum)

Summary

This refactor includes these scaring changes:

avoid id( new A() )->b() and adopt ( new A() )->b() - since PHP 5.4
avoid id( $a->b() )->c() and adopt just $a->b()->c() - since PHP 5.4
avoid dirname(__FILE__) and adopt __DIR__ - since PHP 5.3
avoid $foo ? $foo : $default and adopt $foo ?: $default - since PHP 5.3

To better understand and comment these old PHP features, see:

https://we.phorge.it/T15158

Note that all directories like /__tests__/ were skipped.

Ref T15158
Ref P6

Test Plan

I checked every single line with my big eyes
matrioska test: I hot-used my Arcanist to run arc diff and it worked

Diff Detail

Repository

rARC Arcanist

Branch

T15158-ehm-modernize-codebase-php55

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/conduit/ConduitClient.php:138	XHP1	PHP Syntax Error!
Error	src/hardpoint/ArcanistHardpointObject.php:78	XHP1	PHP Syntax Error!
Error	src/lint/ArcanistLintMessage.php:372	XHP1	PHP Syntax Error!
Error	src/ref/simple/ArcanistSimpleSymbolRefInspector.php:44	XHP1	PHP Syntax Error!
Error	src/ref/symbol/ArcanistSymbolEngine.php:81	XHP1	PHP Syntax Error!
Error	src/repository/api/ArcanistRepositoryAPI.php:782	XHP1	PHP Syntax Error!
Error	src/runtime/ArcanistRuntime.php:561	XHP1	PHP Syntax Error!

Unit

Test Failures

Build Status

Buildable 124
Build 124: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2,943 ms	ArcanistJSHintLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "too-many-errors.lint-test". MISSING MESSAGES Message with severity "disabled" at "2:22" (E043)
	345 ms	ArcanistPhpcsLinterTestCase::testLinter Lint emitted an unexpected set of messages for file "basics.lint-test". MISSING MESSAGES Message with severity "error" at "2:1"
	1,275 ms	PhutilLibraryTestCase::testLibraryMap EXCEPTION (XHPASTSyntaxErrorException): repository/api/ArcanistRepositoryAPI.php: XHPAST Parse Error: syntax error, unexpected T_OBJECT_OPERATOR on line 782 #0 /var/www/arcanist/src/moduleutils/PhutilLibraryMapBuilder.php(63): PhutilLibraryMapBuilder->analyzeLibrary() #1 /var/www/arcanist/src/__tests__/PhutilLibraryTestCase.php(29): PhutilLibraryMapBuilder->buildMap()
	47 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	63 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
		View Full Test Results (3 Failed · 311 Passed · 28 Skipped)

Event Timeline

valerio.bozzolan created this revision.Mar 6 2023, 07:48

Owners added a reviewer: O1: Blessed Committers.Mar 6 2023, 07:48

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 6 2023, 07:48

valerio.bozzolan requested review of this revision.Mar 6 2023, 07:48

Harbormaster completed remote builds in B123: Diff 330.Mar 6 2023, 07:48

avoid to replace CLASS to self::class since it's probably nonsense

https://stackoverflow.com/q/75648554/3451846

Harbormaster completed remote builds in B124: Diff 331.Mar 6 2023, 08:38

valerio.bozzolan edited the summary of this revision. (Show Details)Mar 6 2023, 09:23

skip the replacement of __CLASS__ to self::class since it can be just confusing

Harbormaster completed remote builds in B125: Diff 332.Mar 6 2023, 09:25

valerio.bozzolan edited the summary of this revision. (Show Details)Mar 6 2023, 09:25

I have an ironical situation. This syntax is very supported:

# this is supported since PHP 5.0
$a->b()->c()

But:

# I'm trying to deprecate this
id( $a->b() )->c()

# but this is supported only in PHP 7.0
( $a->b() )->c()

# so to deprecate id() - we have to strip unuseful parenthesis to obtain this that is supported in PHP 5.0:
$a->b()->c()

simplify ( $a->b() )->$b() to just $a->b()->c() since the first it's only supported in PHP 7.0

Yes, $a->b()->c() just work since PHP 5.0 without using tricks like id( $a->b() )->c().

Harbormaster completed remote builds in B126: Diff 333.Mar 6 2023, 10:05

I would like to fix this lint:

Lint emitted an unexpected set of messages for file "basics.lint-test".
MISSING MESSAGES
    Message with severity "error" at "2:1"

SURPLUS MESSAGES
(No messages.)

But - believe me or not but - I truly does not understand what it would want.

valerio.bozzolan edited the summary of this revision. (Show Details)Mar 7 2023, 19:54

I understand that this is... too much.

I will split this Diff in one that is only about with the modification about dirname() and nothing else, so it will be easy-peasy to review. And it will still be a step forward.

Modernize codebase to features available since PHP 5.5AbandonedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 331

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

scripts/__init_script__.php

scripts/arcanist.php

scripts/hgdaemon/hgdaemon_client.php

scripts/hgdaemon/hgdaemon_server.php

src/__phutil_library_init__.php

src/browse/query/ArcanistBrowseCommitHardpointQuery.php

src/browse/query/ArcanistBrowseRevisionURIHardpointQuery.php

src/browse/query/ArcanistBrowseURIHardpointQuery.php

src/browse/workflow/ArcanistBrowseWorkflow.php

src/conduit/ArcanistConduitCallFuture.php

src/conduit/ArcanistConduitEngine.php

src/conduit/ConduitClient.php

src/config/ArcanistConfigurationEngine.php

src/config/arc/ArcanistArcConfigurationEngineExtension.php

src/config/source/ArcanistDefaultsConfigurationSource.php

src/config/source/ArcanistFilesystemConfigurationSource.php

src/configuration/ArcanistConfiguration.php

src/configuration/ArcanistSetting.php

src/console/PhutilConsole.php

src/console/PhutilConsoleMetrics.php

src/console/PhutilConsoleProgressBar.php

src/console/PhutilConsoleServerChannel.php

src/console/PhutilInteractiveEditor.php

src/console/grid/ArcanistGridRow.php

src/console/grid/ArcanistGridView.php

src/console/view/PhutilConsoleTable.php

src/difference/ArcanistDiffUtils.php

src/difference/ArcanistDiffVectorNode.php

src/filesystem/FileFinder.php

src/filesystem/PhutilProcessQuery.php

src/filesystem/binary/PhutilBinaryAnalyzer.php

src/filesystem/binary/PhutilMercurialBinaryAnalyzer.php

src/future/FutureIterator.php

src/future/aws/PhutilAWSFuture.php

src/future/github/PhutilGitHubFuture.php

src/future/http/HTTPSFuture.php

src/future/http/PhutilHTTPEngineExtension.php

src/future/paypal/PhutilPayPalAPIFuture.php

src/future/postmark/PhutilPostmarkFuture.php

src/hardpoint/ArcanistHardpointEngine.php

src/hardpoint/ArcanistHardpointObject.php

src/hardpoint/ArcanistHardpointRequest.php

src/init/init-library.php

src/init/lib/PhutilBootloader.php

src/inspector/ArcanistBrowseRefInspector.php

src/inspector/ArcanistRefInspector.php

src/inspector/ArcanistWorkingCopyStateRefInspector.php

src/internationalization/PhutilLocale.php

src/internationalization/PhutilTranslation.php

src/land/ArcanistLandCommit.php

src/land/engine/ArcanistGitLandEngine.php

src/land/engine/ArcanistLandEngine.php

src/land/engine/ArcanistMercurialLandEngine.php

src/lint/ArcanistLintMessage.php

src/lint/engine/ArcanistComprehensiveLintEngine.php

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php

src/lint/engine/ArcanistLintEngine.php

src/lint/linter/ArcanistCSSLintLinter.php

src/lint/linter/ArcanistCSharpLinter.php

src/lint/linter/ArcanistClosureLinter.php

src/lint/linter/ArcanistCoffeeLintLinter.php

src/lint/linter/ArcanistFutureLinter.php

src/lint/linter/ArcanistJSONLinter.php

src/lint/linter/ArcanistLinter.php

src/lint/linter/ArcanistPhpLinter.php

src/lint/linter/ArcanistPhpcsLinter.php

src/lint/linter/ArcanistPhutilLibraryLinter.php

src/lint/linter/ArcanistPuppetLintLinter.php

src/lint/linter/ArcanistPyLintLinter.php

src/lint/linter/ArcanistRuboCopLinter.php

src/lint/linter/ArcanistScriptAndRegexLinter.php

Modernize codebase to features available since PHP 5.5
AbandonedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List