Fix "Undefined index: icon" when visiting Search Servers using MySQL
NOTE: This patch just fixes the exception at my best but this section probably deserves more improvement to show a better default.
Closes T15155
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15155: Fix RuntimeException "Undefined index: icon" when visiting Search Servers using MySQL
- Commits
- rP66192a5b832c: Fix "Undefined index: icon" when visiting Search Servers using MySQL
- use the default Search Server configuration (that is MySQL)
- open the page Search Servers (/config/cluster/search/)
- verify that it does not explode anymore but it displays something unuseful
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15155-fix-search-servers-array-status-icon
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 121 Build 121: arc lint + arc unit
Event Timeline
Comment Actions
This is how it will render after this change:
It's just something to avoid that exception.
It can surely improve saying that it's "Active" but it's probably not appropriate to assume this positive status condition in this position, and so any further improvement about the status itself is probably out of the scope of this fix and should be put in the getConnectionStatus() method maybe.
| src/applications/config/controller/services/PhabricatorConfigClusterSearchController.php | ||
|---|---|---|
| 78 | NOTE: I'm not very happy about the fact that here we are, in a single line, creating the array and assigning the first value.
But I think it's out of the scope of this patch to improve that part. | |