Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Commits

rP20fb93d1a4be: Add small documentation details

Summary

Add some small Diviner documentation details like:

mention PHP 8.1 (thanks https://we.phorge.it/Q18)
mention the fact that you need multiple databases (it may be not obvious from the startup)
mention MariaDB and not just MySQL (thanks MariaDB community!)
mention "Administrator" and not just "User" for the "Instructions for installing, configuring, and using Phorge."

I was not bold enough to do more changes.

Test Plan

I tested locally and Diviner does not look bad.

Diff Detail

Repository

rP Phorge

Branch

diviner-php-version

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/docs/book/user.book:5	TXT3	Line Too Long

Unit

No Test Coverage

Build Status

Buildable 108
Build 108: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Feb 9 2023, 17:19

Owners added a reviewer: O1: Blessed Committers.Feb 9 2023, 17:19

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptFeb 9 2023, 17:19

valerio.bozzolan requested review of this revision.Feb 9 2023, 17:19

Harbormaster completed remote builds in B108: Diff 309.Feb 9 2023, 17:19

mention "Administrator" and not just "User" (not just end-users)

Harbormaster completed remote builds in B109: Diff 310.Feb 9 2023, 17:21

valerio.bozzolan retitled this revision from add more documentation details to Add small documentation details.Feb 9 2023, 17:24

valerio.bozzolan edited the summary of this revision. (Show Details)

This is just a small change but if you want a spoiler, here how it looks like:

Diviner proposed home.png (350×877 px, 43 KB)

Note the first section, that now it's not just for "Users" but it also mentions "Administrator".

(I know that an "administrator" is a kind of "user", but some administrators never read "user documentation", and that's why I think this small change could somehow better orient prominently).

valerio.bozzolan mentioned this in Q18: Lowest and Highest supported PHP (Answer 14).Feb 9 2023, 17:31

avivey subscribed.Feb 9 2023, 19:37

avivey added inline comments.