To ensure compatibility of PHP code with PHP 8.x
There's some breaking changes in 8.1 and 8.2.
To ensure compatibility of PHP code with PHP 8.x
There's some breaking changes in 8.1 and 8.2.
@mturdus: Could you land this one please, or would you like any help? Thanks!
Patch based on my understanding of taavi's comments in T15963 (as I fail to set up an LDAP server locally):
diff --git a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php index 14047c1761..e25659a4aa 100644 --- a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php +++ b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php @@ -305,7 +305,16 @@ final class PhutilLDAPAuthAdapter extends PhutilAuthAdapter { 'port' => $this->port, ));
Done. Thank you for your tips!
@xtex: Hi, would you like to arc land your patch? Or do you need any help? Thanks!
arc lint arc unit
Thanks. I can confirm with PHP 8.4.4 after upgrading one of my machines.
Probably same game as T15679 somewhere in src/applications/phriction/controller/PhrictionMoveController.php
@mturdus: Could you land this one please, or would you like any help? Thanks!