Page MenuHomePhorge

PHP 8 supportTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

To ensure compatibility of PHP code with PHP 8.x

There's some breaking changes in 8.1 and 8.2.

Recent Activity

Fri, Apr 19

aklapper added a revision to T15679: Pholio image upload triggers Passing null is deprecated at PhabricatorPolicyQuery.php:314: D25600: Mark created Pholio mockups as new objects to fix empty Feed transaction entries.
Fri, Apr 19, 16:30 · PHP 8 support
aklapper added a revision to T15794: PHP 8.1 "strlen(null)" exceptions mass-editing tasks when custom Date field present: D25599: Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present.
Fri, Apr 19, 15:56 · PHP 8 support
aklapper created T15794: PHP 8.1 "strlen(null)" exceptions mass-editing tasks when custom Date field present.
Fri, Apr 19, 15:30 · PHP 8 support

Thu, Apr 18

aklapper added a revision to T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined: D25596: Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:50 · PHP 8 support
aklapper renamed T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined from PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel to PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:47 · PHP 8 support
aklapper updated the task description for T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:44 · PHP 8 support
aklapper created T15791: PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined.
Thu, Apr 18, 17:41 · PHP 8 support

Mon, Apr 15

aklapper added a revision to T15786: PHP 8.1 "strlen(null)" exceptions adding an OAuth provider: D25578: Fix PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
Mon, Apr 15, 15:00 · PHP 8 support
aklapper created T15786: PHP 8.1 "strlen(null)" exceptions adding an OAuth provider.
Mon, Apr 15, 14:58 · PHP 8 support

Thu, Apr 4

aklapper removed a subtask for T15223: Fix Phorge PhabricatorFactDaemon::run() in PHP 8.2: Passing null to parameter #1 ($string) of type string is deprecated: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Thu, Apr 4, 21:39 · PHP 8 support
aklapper removed a parent task for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies: T15223: Fix Phorge PhabricatorFactDaemon::run() in PHP 8.2: Passing null to parameter #1 ($string) of type string is deprecated.
Thu, Apr 4, 21:39 · Documentation, PHP 8 support, Arcanist, User-valerio.bozzolan

Wed, Apr 3

aklapper closed T15770: PHP 8.1 "preg_match(null)" exception exporting task list to CSV, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Wed, Apr 3, 09:57 · PHP 8 support
aklapper closed T15770: PHP 8.1 "preg_match(null)" exception exporting task list to CSV as Resolved by committing rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV.
Wed, Apr 3, 09:57 · PHP 8 support

Tue, Apr 2

aklapper added a revision to T15770: PHP 8.1 "preg_match(null)" exception exporting task list to CSV: D25567: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV.
Tue, Apr 2, 20:31 · PHP 8 support
aklapper created T15770: PHP 8.1 "preg_match(null)" exception exporting task list to CSV.
Tue, Apr 2, 20:30 · PHP 8 support
valerio.bozzolan triaged T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping" as Low priority.

Looking at the mentioned question, it seems a NULL pointer arrives as first argument in phutil_encode_log(). Fortunately that function is used by only 3 places:

Tue, Apr 2, 07:18 · PHP 8 support

Mon, Apr 1

aklapper closed T15761: PHP 8.1 "strlen(null)" exception entering autocomplete project tag in task comment, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Mon, Apr 1, 08:40 · PHP 8 support
aklapper closed T15761: PHP 8.1 "strlen(null)" exception entering autocomplete project tag in task comment as Resolved by committing rP713188bf1710: Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete….
Mon, Apr 1, 08:40 · PHP 8 support

Sun, Mar 31

aklapper closed T15765: PHP 8.2 error: "Creation of dynamic property MimeMailParser::$parts is deprecated", a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sun, Mar 31, 13:25 · PHP 8 support
aklapper closed T15765: PHP 8.2 error: "Creation of dynamic property MimeMailParser::$parts is deprecated" as Resolved by committing rPa69db10c5e15: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.
Sun, Mar 31, 13:25 · PHP 8 support
aklapper closed T15767: PHP 8.1 "strlen(null)" exception when received email lacks From header, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sun, Mar 31, 13:21 · PHP 8 support
aklapper closed T15767: PHP 8.1 "strlen(null)" exception when received email lacks From header as Resolved by committing rP186768ccfd88: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header.
Sun, Mar 31, 13:21 · PHP 8 support
aklapper added a revision to T15767: PHP 8.1 "strlen(null)" exception when received email lacks From header: D25564: Fix PHP 8.1 "strlen(null)" exception when received email lacks From header.
Sun, Mar 31, 11:54 · PHP 8 support
aklapper created T15767: PHP 8.1 "strlen(null)" exception when received email lacks From header.
Sun, Mar 31, 11:51 · PHP 8 support

Fri, Mar 29

aklapper added a revision to T15765: PHP 8.2 error: "Creation of dynamic property MimeMailParser::$parts is deprecated": D25563: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.
Fri, Mar 29, 11:37 · PHP 8 support
aklapper created T15765: PHP 8.2 error: "Creation of dynamic property MimeMailParser::$parts is deprecated".
Fri, Mar 29, 11:36 · PHP 8 support

Mar 21 2024

aklapper added a revision to T15761: PHP 8.1 "strlen(null)" exception entering autocomplete project tag in task comment: D25556: Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined.
Mar 21 2024, 17:36 · PHP 8 support
aklapper created T15761: PHP 8.1 "strlen(null)" exception entering autocomplete project tag in task comment.
Mar 21 2024, 17:30 · PHP 8 support

Mar 1 2024

aklapper added a revision to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping": D25483: fix PHP 8 "strlen(null)" when testing the ssh setup.
Mar 1 2024, 12:35 · PHP 8 support
aklapper renamed T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping" from Fresh batch of PHP 8 deprecated use of strlen with a NULL argument to PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".
Mar 1 2024, 12:35 · PHP 8 support
aklapper added a comment to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".

Second issue got already fixed by rPa7fb04f96c92d4ff57ac8c01213e6dd73a03f5d6 which wasn't linked to this ticket

Mar 1 2024, 12:34 · PHP 8 support
aklapper added a comment to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".

@jeanguyomarch: If you could provide stacktraces of these issues, that would be awesome.

Mar 1 2024, 12:27 · PHP 8 support
aklapper added a comment to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".

First part is D25483

Mar 1 2024, 12:27 · PHP 8 support

Feb 23 2024

avivey added a revision to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3: D25539: Fix an instance of `strlen(null)`.
Feb 23 2024, 11:29 · PHP 8 support

Feb 13 2024

sirocyl closed T15737: Include information for installing required PHP version in Diviner docs as Wontfix.
Feb 13 2024, 03:34 · PHP 8 support, Good Starter Task, Documentation

Feb 12 2024

avivey added a revision to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3: D25537: Update PHP versions in install guide: Remove 5, Add 8..
Feb 12 2024, 20:35 · PHP 8 support
avivey added a revision to T15737: Include information for installing required PHP version in Diviner docs: D25537: Update PHP versions in install guide: Remove 5, Add 8..
Feb 12 2024, 20:35 · PHP 8 support, Good Starter Task, Documentation
aklapper closed T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Feb 12 2024, 12:26 · PHP 8 support
aklapper closed T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured as Resolved by committing rP052b5f41c705: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Feb 12 2024, 12:26 · PHP 8 support
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.

On it, thank you!

Feb 12 2024, 10:47 · PHP 8 support, Good Starter Task, Documentation
valerio.bozzolan added a comment to T15737: Include information for installing required PHP version in Diviner docs.

My friend, I think you are affected by this change, and this applies to whatever PHP version

Feb 12 2024, 10:46 · PHP 8 support, Good Starter Task, Documentation
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.

I'm on the latest pull, commit f81e821abf2b275d1778d02a018a4d0af7208be8.
A bit off topic here :) but I'll quickly sum up the issue I'm having (and am in the middle of trying things to fix):

  • Visiting https://[phorge instance]/auth/config/view/2/, where my Github auth item is, makes nginx dump a blank 502 page, no further info.
  • First instinct is to check the /var/log/nginx/error.log, where I get a PHP stack trace concatenated into one line, and an nginx header length error (reformatted for readability. the PHP error is truncated):
Feb 12 2024, 10:35 · PHP 8 support, Good Starter Task, Documentation
avivey added a comment to T15737: Include information for installing required PHP version in Diviner docs.

Oh, totally possible that I forgot to update it :)

Feb 12 2024, 10:14 · PHP 8 support, Good Starter Task, Documentation
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.

I'll take your word on it that it's supported, though the current installation guide says otherwise.
Further, I had a few roadbumps on a fresh install to a new server with PHP 8, that I suspect may relate to strlen(NULL) behavior, but I did need to set up PHP 7 to make sure that was or wasn't the case.
(I'm in the process of reproducing those and working out a possible cause or trace. Some manifested as warning banners, one as a 502 on my end in the GitHub auth provider.)

Feb 12 2024, 10:01 · PHP 8 support, Good Starter Task, Documentation
avivey added a comment to T15737: Include information for installing required PHP version in Diviner docs.

We already support PHP 8...

Feb 12 2024, 09:44 · PHP 8 support, Good Starter Task, Documentation
sirocyl updated the task description for T15737: Include information for installing required PHP version in Diviner docs.
Feb 12 2024, 07:38 · PHP 8 support, Good Starter Task, Documentation
sirocyl updated the task description for T15737: Include information for installing required PHP version in Diviner docs.
Feb 12 2024, 07:37 · PHP 8 support, Good Starter Task, Documentation
sirocyl created T15737: Include information for installing required PHP version in Diviner docs.
Feb 12 2024, 07:36 · PHP 8 support, Good Starter Task, Documentation

Feb 6 2024

speck added a revision to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3: D25534: T15064: Several arcanist PHP 8.1 compat issues on Windows.
Feb 6 2024, 03:42 · PHP 8 support

Feb 5 2024

aklapper closed T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Feb 5 2024, 15:09 · PHP 8 support