User Details
- User Since
- Apr 12 2023, 05:12 (83 w, 4 d)
- Availability
- Available
Jul 22 2023
@avivey Yes I think this is what we need.
There is a caveat though:
Jul 7 2023
It does seem like it is not designed for development use either..
Why do you say so?
Phorge works perfectly AFAIK with the development webserver. That is just a single command, without having to install Apache.
Jul 5 2023
@speck I think I can see now where we have fundamental differences in our views.
Thanks for your replies!
Jul 4 2023
I posted this in a separate thread, but it is definitely related: https://we.phorge.it/T15524
Jun 24 2023
Jun 22 2023
May 15 2023
Chaining Diffs is something that we would like to use more often, and it is definitely not used enough today. FreeBSD is a large codebase and making any change that is bigger than trivial often involves touching multiple parts of the system, the most difficult kind of change is architectural changes. We are limited by our tooling to a certain degree:
- Keeping everything in one Diff makes it very difficult to review as well as reach consensus, as there are often multiple responsible parties involved. It also violates the ethos of Phab/Phorge of having small atomic changes.
- Breaking changes down in smaller chunks has lots of downsides too - it is very hard to track and changes often get lost in depths of Differential.
May 9 2023
May 8 2023
@valerio.bozzolan right, I forgot the important bit, sorry :D
In an ideal world the solution should be as simple as having a template somewhere in {{repo_root}}/.arcanist/commit_template.j2 that arcanist injects values in and renders.
arc patch problem is likely fixed. But I encountered similar problem here
https://we.phorge.it/T15351#8287
This seems to have fixed the problem. But let me try a bit more Diffs to be extra sure
I see what you are saying. I quite like Lua and how neovim uses it to achieve this extensibility...
May 7 2023
@speck the whole point of an alternative phab client implementation is remove friction that comes with arcanist. Namely:
The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already
re @avivey : arc land --hold sort of works but look at the ergonomics:
May 6 2023
more details about arc land - https://we.phorge.it/T15364
Thanks @avivey !
May 5 2023
Apr 28 2023
@avivey many developers do not use arcanist at all for reasons outlined in https://we.phorge.it/T15096#6224 - many do not wish to install php, some find arc interface confusing...
Apr 17 2023
It is hard to say objectively, as I am new to PHP and to this codebase in particular. In total I spent probably 4-6 hours over the weekend, but someone with more experience could've done a lot more in that time. I was reading about PHP, setting up my dev environment, reading the code, navigating class hierarchy, trying to understand PHP idioms, etc. In the end of the day I realized that learning yet another language (and TBH not the most sexy one) in my free time to hack on a gigantic legacy codebase is not something that I want to do.
Ok, after spending a weekend looking at PHP I can say that I overestimated my level of enthusiasm. This is the kind of work that I'd like to get paid for and not spend my free time on.
Sorry @avivey, but you can cross me off the list of potential code contributors.
Apr 14 2023
@valerio.bozzolan yes, https://gitpull.it/D110 demonstrates the point I was trying to communicate. No buttons available to expand the context.
Having been invited to chime in from Q46 I will leave my 2 cents here:
Apr 13 2023
I don't mind if someone points me at the right place in code so I can try my luck with writing PHP.
Thanks, will do!
Test Edit comment