Page MenuHomePhorge

Workboard Columns: avoid page reload on Edit > Cancel
ClosedPublic

Authored by valerio.bozzolan on Jun 16 2023, 23:33.
Tags
None
Referenced Files
F3405870: D25302.1744582342.diff
Sat, Apr 12, 22:12
F3372679: D25302.1744250851.diff
Wed, Apr 9, 02:07
F3372456: D25302.1744249935.diff
Wed, Apr 9, 01:52
F3372438: D25302.1744249858.diff
Wed, Apr 9, 01:50
F3367810: D25302.1744203372.diff
Tue, Apr 8, 12:56
F3362452: D25302.1744083241.diff
Mon, Apr 7, 03:34
F3357966: D25302.1743916577.diff
Sat, Apr 5, 05:16
F3357475: D25302.1743913190.diff
Sat, Apr 5, 04:19

Details

Summary

The rationale for this change is that reloading a page unnecessarily wastes
resources that we can save.

This includes human resources (time) but also computational resources
as well. We probably save a fawn for every 1,000 clicks on that button.
A message to Greta Thunberg: now Phorge is with you.

This is the involved "Cancel" button, that does not reload the page anymore:

Archive and Hide Column Cancel button.png (197×864 px, 31 KB)

Closes T15471

Test Plan

Workboard > Column > Edit > Cancel:

The popup closes gracefully instead of a page refresh.

Also try opening the workflow in another tab (/project/board/1/hide/2/) > Cancel:

You turn back to your Workboard just as before.

Diff Detail

Repository
rP Phorge
Branch
workboard-edit-undo-avoid-reloaaaad
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 571
Build 571: arc lint + arc unit

Event Timeline

valerio.bozzolan retitled this revision from Workboard: avoid page reload when clicking on Edit > Cancel to Workboard Columns: avoid page reload on Edit > Cancel.Jun 16 2023, 23:37

This one-line change is a present for my friend @Matthew

The test plan is just 2 clicks

But reviewing this is the price @Matthew :D (you know ihih)

Sorry, didn't see your earlier ping. Approved.

This revision is now accepted and ready to land.Jul 28 2023, 16:40