Paths

Table of Contentst

Differential D25262

Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface
ClosedPublic
Actions

Authored by aklapper on May 30 2023, 10:22.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 12:43

	Unknown Object (File)
	Sat, Apr 27, 11:41

	Unknown Object (File)
	Sat, Apr 27, 08:59

	Unknown Object (File)
	Sat, Apr 27, 04:25

	Unknown Object (File)
	Sun, Apr 21, 23:25

	Unknown Object (File)
	Sat, Apr 20, 17:50

	Unknown Object (File)
	Thu, Apr 11, 11:19

	Unknown Object (File)
	Sun, Apr 7, 09:35

View All 66 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15430: PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface

Commits

rPdd24c94b0741: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=18554ea76ceb), phorge(head=diffDiff, ref.master=e11c5486c92b, ref.diffDiff=e11c5486c92b)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php:160]

Closes T15430

Test Plan

After applying these two changes, going to /differential/diff/create/, pasting the content of a diff file into the "Raw Diff" field, and selecting the "Create Diff" button, /differential/diff/1/ rendered correctly in web browser.

Also, install xdebug and try again with coverage mode enabled in your php.ini of your PHP cli.

Diff Detail

Repository

Branch

diffDiff (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 485
Build 485: arc lint + arc unit

Event Timeline

aklapper created this revision.May 30 2023, 10:22

Owners added a reviewer: O1: Blessed Committers.May 30 2023, 10:22

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 30 2023, 10:22

aklapper requested review of this revision.May 30 2023, 10:22

Harbormaster completed remote builds in B485: Diff 850.May 30 2023, 10:22

aklapper mentioned this in T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential.May 30 2023, 10:34

aklapper mentioned this in D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.May 30 2023, 10:35

aklapper mentioned this in T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page.May 30 2023, 10:59

aklapper mentioned this in D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.May 30 2023, 11:05

valerio.bozzolan edited the test plan for this revision. (Show Details)Jun 2 2023, 18:23

Wow. I discovered coverage.

sudo apt install php-xdebug

Then in my PHP.ini of PHP cli:

xdebug.mode=coverage

And boom, there is coverage.

When enabled, this is a train of characters inside a big string. So indeed this is a string.

Hoping to be useful I will add a small PHP documentation.

Thanks!

sgtm

This revision is now accepted and ready to land.Jun 2 2023, 18:31

add a small PHPDoc (honestly, just to trigger again the Coverage)

Harbormaster completed remote builds in B502: Diff 874.Jun 2 2023, 18:32

Wow! I tested this in production, see the lovely bars on the right about the Coverage. Interesting.

Closed by commit rPdd24c94b0741: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web…. · Explain WhyJun 2 2023, 18:40

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPdd24c94b0741: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web….

aklapper mentioned this in rP44a8a1c408ed: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in….Jun 8 2023, 12:48

aklapper mentioned this in rP25c4f6224d63: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

diff/

view/

PHUIDiffTableOfContentsItemView.php

4 lines

O1: Blessed Committers

Diff 850

src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php

Loading...