If your Config page was showing some "Unknown" fields, this change is useful,
since it allows you to fix your situation from the .gitconfig of the
user running your webserver.
Before this change, some git commands here were executed without any HOME, so,
git was not opening any .gitconfig, so, any repository marked as "safe" was just
not assumed as safe, so, git was quitting with the exit status 128 with the famous
"detected dubious ownership" error, so, Phorge was not able to run "git log" and
identify the current version, so, Phorge was showing an "Unknown" version.
After this change, these git commands now have the HOME.
You could definitely still have that error. But at least, now you can fix.
After this change, in most cases, git will try to open this file:
/var/www/.gitconfig
So if you want to fix the "detected dubious ownership", now that file is considered,
so you can try to fix with this configuration or a similar one:
[safe]
directory = /var/www/arcanist
directory = /var/www/phorgeNote that in normal conditions that configuration is generated from a similar git
global command, but you must issue this from your webserver user:
git config --global --add safe.directory /var/www/phorge
The only current workaround was to fix at --system level instead of --global.
