Correct two spelling mistakes in Differential
ClosedPublic
Actions

Authored by aklapper on May 28 2023, 13:31.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T15269: Typos in English Differential strings: "Hold revision as as draft."; "You can not plan changes to this this revision"

Commits

rPf2329f816504: Correct two spelling mistakes in Differential

Summary

Closes T15269

Test Plan

Only changes to spelling.

Diff Detail

Repository

rP Phorge

Branch

typofix15269 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 470
Build 470: arc lint + arc unit

Event Timeline

aklapper created this revision.May 28 2023, 13:31

Owners added a reviewer: O1: Blessed Committers.May 28 2023, 13:31

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 28 2023, 13:31

aklapper requested review of this revision.May 28 2023, 13:31

Harbormaster completed remote builds in B470: Diff 826.May 28 2023, 13:31

Uh, interesting typos. Premising I'm not native English but indeed they seem obvious to me.

lgtm

src/applications/differential/editor/DifferentialRevisionEditEngine.php
310	✅ I verified this line with my big eyes
src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
89	✅ I verified this line with my big eyes

This revision is now accepted and ready to land.May 29 2023, 19:33

Closed by commit rPf2329f816504: Correct two spelling mistakes in Differential. · Explain WhyMay 30 2023, 08:46

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPf2329f816504: Correct two spelling mistakes in Differential.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

2 lines

O1: Blessed Committers

xaction/

DifferentialRevisionPlanChangesTransaction.php

2 lines

O1: Blessed Committers

Diff 826

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php