Page MenuHomePhorge
Differential D25252

Correct two spelling mistakes in Differential
ClosedPublic
Actions

Authored by aklapper on May 28 2023, 13:31.
Tags
None
Referenced Files
F3333193: D25252.1743532161.diff
Mon, Mar 31, 18:29
F3333072: D25252.1743529855.diff
Mon, Mar 31, 17:50
F3331196: D25252.1743502744.diff
Mon, Mar 31, 10:19
F3328752: D25252.1743461739.diff
Sun, Mar 30, 22:55
F3319631: D25252.1743311964.diff
Sat, Mar 29, 05:19
F3303584: D25252.1743083612.diff
Wed, Mar 26, 13:53
F3299493: D25252.1743022983.diff
Tue, Mar 25, 21:03
F3299160: D25252.1743016170.diff
Tue, Mar 25, 19:09
View All 34 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15269: Typos in English Differential strings: "Hold revision as as draft."; "You can not plan changes to this this revision"
Commits
rPf2329f816504: Correct two spelling mistakes in Differential
Summary

Closes T15269

Test Plan

Only changes to spelling.

Diff Detail

Repository
rP Phorge
Branch
typofix15269 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 470
Build 470: arc lint + arc unit

Event Timeline

aklapper created this revision.May 28 2023, 13:31
Owners added a reviewer: O1: Blessed Committers.May 28 2023, 13:31
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 28 2023, 13:31
aklapper requested review of this revision.May 28 2023, 13:31
Harbormaster completed remote builds in B470: Diff 826.May 28 2023, 13:31
valerio.bozzolan accepted this revision.May 29 2023, 19:33

Uh, interesting typos. Premising I'm not native English but indeed they seem obvious to me.

lgtm

src/applications/differential/editor/DifferentialRevisionEditEngine.php
310

✅ I verified this line with my big eyes

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php
89

✅ I verified this line with my big eyes

This revision is now accepted and ready to land.May 29 2023, 19:33
Closed by commit rPf2329f816504: Correct two spelling mistakes in Differential. · Explain WhyMay 30 2023, 08:46
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPf2329f816504: Correct two spelling mistakes in Differential.

Revision Contents
Changeset List

Diff 826

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0