valerio.bozzolan retitled this revision from Documentation: mention strlen() deprecation since PHP 8.1 - improve a bit PHP Pitfalls to mention strlen() deprecation - mention is_string() benefits - mention phutil_nonempty_string() - link PHP Pitfalls from PHP Contributors Manual to Documentation: mention strlen() deprecation since PHP 8.1.Apr 2 2023, 19:26

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added inline comments.

src/docs/flavor/php_pitfalls.diviner
63	I moved this text under the section "Check for non-empty strings"
93	I just indented a bit

valerio.bozzolan edited the summary of this revision. (Show Details)Apr 2 2023, 19:31

valerio.bozzolan added a task: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.

valerio.bozzolan mentioned this in Z1: Phorge.Apr 3 2023, 07:53

Cigaryno accepted this revision.Apr 3 2023, 10:12

Cigaryno added a project: Documentation.

If you need a preview:

http://web.archive.org/web/20230406131450/https://gitpull.it/book/flavor/article/php_pitfalls/

valerio.bozzolan retitled this revision from Documentation: mention strlen() deprecation since PHP 8.1 to PHP Pitfalls: mention strlen() deprecation since PHP 8.1.Apr 6 2023, 18:34

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added inline comments.May 12 2023, 10:12

src/docs/flavor/php_pitfalls.diviner
152	↑ That part was just copy-pasted mostly from the already-existing block ↓ This part is new

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

mention the cast thing

Harbormaster completed remote builds in B456: Diff 807.May 25 2023, 10:19

mention the cast thing

Harbormaster completed remote builds in B457: Diff 808.May 25 2023, 10:21

valerio.bozzolan edited the summary of this revision. (Show Details)May 25 2023, 10:22

avoid unuseful tables

Harbormaster completed remote builds in B458: Diff 809.May 25 2023, 10:28

Note that I like to do NOT mention the stuff phutil_nonempty_stringlike() since it causes extra headaches with incoming objects to many friends. Same for its friend phutil_nonempty_scalar() since it's broken with known scalars (T15239).

avivey accepted this revision.May 25 2023, 10:58

This revision is now accepted and ready to land.May 25 2023, 10:58

Closed by commit rP55596bfad523: PHP Pitfalls: mention strlen() deprecation since PHP 8.1. · Explain WhyMay 25 2023, 11:43

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP55596bfad523: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.

PHP Pitfalls: mention strlen() deprecation since PHP 8.1
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 810

src/docs/contributor/php_coding_standards.diviner

src/docs/flavor/php_pitfalls.diviner

PHP Pitfalls: mention strlen() deprecation since PHP 8.1ClosedPublicActions