Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf
ClosedPublic
Actions

Authored by aklapper on May 8 2023, 08:52.

Details

Reviewers

valerio.bozzolan
jgleeson

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15352: Remove outdated PHP version suffixes in package names on "Missing Required Extensions" and replace yum with dnf

Commits

rP17ebf3a11fb5: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf

Summary

Explicitly mentioning PHP5 packages is outdated and confusing.
Also, mentioning dnf together with yum (apparently yum is still in use!). Good for yum users.

Closes T15352

Test Plan

Applied this change and strings on the "Missing Required Extensions" page rendered as expected.

Diff Detail

Repository

rP Phorge

Branch

T15352 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 378
Build 378: arc lint + arc unit

Event Timeline

aklapper created this revision.May 8 2023, 08:52

Owners added a reviewer: O1: Blessed Committers.May 8 2023, 08:52

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 8 2023, 08:52

aklapper requested review of this revision.May 8 2023, 08:52

Harbormaster completed remote builds in B376: Diff 682.May 8 2023, 08:52

Premising I 100% agree in the removal of version suffix and I would +1 just that.

But the -yum +dnf could cause mental problems for users that still use CentOS 7 and maybe others. Probably it would be better to add a line, instead of replacing. (CentOS user reading this: PLEASE MIGRATE ihih)

Uhm, remove now duplicated package name. Heh.

Harbormaster completed remote builds in B378: Diff 691.May 8 2023, 12:41

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

Thanks for this patch,

I'm not bold enough to approve as O1 since they would probably like to keep the "yum" stuff or at least mention both for legacy reasons

So, if you rollback to yum, or if you mention both apt, dnf and yum, I will approve as O1 (without risk of being lynched later)

In D25203#6703, @valerio.bozzolan wrote:

I'm not bold enough to approve as O1 since they would probably like to keep the "yum" stuff or at least mention both for legacy reasons

For context, I did some quick research:

RHEL 9.x docs use dnf but they still officially support yum:

In Red Hat Enterprise Linux 9, software installation is ensured by the DNF tool. Red Hat continues to support the usage of the yum term for consistency with previous major versions of RHEL. If you type yum instead of dnf, the command works as expected because both are aliases for compatibility.

RHEL 8.x (still actively maintained) docs use yum commands throughout:

In RHEL 8, software installation is enabled by the new version of the YUM tool (YUM v4), which is based on the DNF technology.

So, strictly speaking, the usage of yum can't yet be considered outdated or legacy.

Keep yum included

Harbormaster completed remote builds in B423: Diff 758.May 20 2023, 12:22

valerio.bozzolan retitled this revision from Remove PHP version suffixes on "Missing Required Extensions"; Replace yum with dnf to Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.May 20 2023, 12:55

valerio.bozzolan edited the summary of this revision. (Show Details)