Page MenuHomePhorge

Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf
ClosedPublic

Authored by aklapper on May 8 2023, 08:52.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 08:38
Unknown Object (File)
Tue, Mar 26, 07:57
Unknown Object (File)
Tue, Mar 26, 07:28
Unknown Object (File)
Sun, Mar 24, 06:32
Unknown Object (File)
Wed, Mar 20, 10:36

Details

Summary

Explicitly mentioning PHP5 packages is outdated and confusing.
Also, mentioning dnf together with yum (apparently yum is still in use!). Good for yum users.

Closes T15352

Test Plan

Applied this change and strings on the "Missing Required Extensions" page rendered as expected.

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25203
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 423
Build 423: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.May 8 2023, 08:52

Premising I 100% agree in the removal of version suffix and I would +1 just that.

But the -yum +dnf could cause mental problems for users that still use CentOS 7 and maybe others. Probably it would be better to add a line, instead of replacing. (CentOS user reading this: PLEASE MIGRATE ihih)

Uhm, remove now duplicated package name. Heh.

Thanks for this patch,

I'm not bold enough to approve as O1 since they would probably like to keep the "yum" stuff or at least mention both for legacy reasons

So, if you rollback to yum, or if you mention both apt, dnf and yum, I will approve as O1 (without risk of being lynched later)

I'm not bold enough to approve as O1 since they would probably like to keep the "yum" stuff or at least mention both for legacy reasons

For context, I did some quick research:

In Red Hat Enterprise Linux 9, software installation is ensured by the DNF tool. Red Hat continues to support the usage of the yum term for consistency with previous major versions of RHEL. If you type yum instead of dnf, the command works as expected because both are aliases for compatibility.

RHEL 8.x (still actively maintained) docs use yum commands throughout:

In RHEL 8, software installation is enabled by the new version of the YUM tool (YUM v4), which is based on the DNF technology.

So, strictly speaking, the usage of yum can't yet be considered outdated or legacy.

valerio.bozzolan retitled this revision from Remove PHP version suffixes on "Missing Required Extensions"; Replace yum with dnf to Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.May 20 2023, 12:55
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the summary of this revision. (Show Details)
jgleeson subscribed.

I've tested this locally and can see the new dnf install command

Screenshot from 2023-05-20 15-56-17.png (1×1 px, 212 KB)

Thanks for this patch also from me and for your changes

Tested this locally, and seems perfectly legit to mention dnf together with yum.

There is some margin to improve this of course in the future, for example resolving that "TODO"

Green light from me

sgtm

This revision is now accepted and ready to land.May 20 2023, 14:00