Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page when Reports prototype enabled
ClosedPublic
Actions

Authored by aklapper on May 6 2023, 13:33.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15360: PHP 8.1 "strlen(null)" exception blocks rendering a project's page when Reports prototype enabled

Commits

rPaa8baf1c8b59: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This is exactly the same case as D25140.

Closes T15360

Test Plan

Applied this change and /project/view/1/ rendered the workboard in the web browser as expected.

Diff Detail

Repository

rP Phorge

Branch

projViewReportsProtoEnabled (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 371
Build 371: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	175 ms	PhabricatorProjectCoreTestCase::testAncestorMembers EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	78 ms	PhabricatorProjectCoreTestCase::testColumnExtendedPolicies EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	82 ms	PhabricatorProjectCoreTestCase::testIsViewerMemberOrWatcher EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	92 ms	PhabricatorProjectCoreTestCase::testJoinLeaveProject EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
	120 ms	PhabricatorProjectCoreTestCase::testParentProject EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
		View Full Test Results (6 Failed · 24 Passed)

Event Timeline

aklapper created this revision.May 6 2023, 13:33

Owners added a reviewer: O1: Blessed Committers.May 6 2023, 13:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 6 2023, 13:33

aklapper requested review of this revision.May 6 2023, 13:33

Harbormaster completed remote builds in B371: Diff 675.May 6 2023, 13:34

aklapper retitled this revision from Fix PHP 8.1 "strlen(null)" exception[s] which block rendering the XXXX page to Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page when Reports prototype enabled.May 6 2023, 13:34

Thanks for this patch

I tested this locally logging $name and I confirm the bind between that and the menu name, that so it's a string or null (default).

The function phutil_nonempty_string() will report alien values, and that is OK here.

The lint errors are TOTALLY UNRELATED and related to T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float "

This revision is now accepted and ready to land.May 8 2023, 11:51

This revision was landed with ongoing or failed builds.May 8 2023, 12:35

Closed by commit rPaa8baf1c8b59: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page…. · Explain Why

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPaa8baf1c8b59: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page….