Page MenuHomePhorge
Differential D25173

Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure Menu page
ClosedPublic
Actions

Authored by aklapper on May 1 2023, 23:01.
Tags
None
Referenced Files
F3298921: D25173.1743012067.diff
Tue, Mar 25, 18:01
F3298638: D25173.1743006682.diff
Tue, Mar 25, 16:31
F3298596: D25173.1743005173.diff
Tue, Mar 25, 16:06
F3286025: D25173.1742810002.diff
Sun, Mar 23, 09:53
F3284415: D25173.1742775861.diff
Sun, Mar 23, 00:24
F3251845: D25173.1742377712.diff
Tue, Mar 18, 09:48
F3248516: D25173.1742259991.diff
Mon, Mar 17, 01:06
F3220719: D25173.1741813061.diff
Tue, Mar 11, 20:57
View All 23 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15327: PHP 8.1 "strlen(null)" exception blocks rendering project's Configure Menu page
Commits
rPb0cfb6ca6aca: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure…
Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15327

Test Plan

Applied this change (on top of D25166) and /project/1/item/configure/ rendered in web browser.

Diff Detail

Repository
rP Phorge
Branch
T15327 (branched from master)
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 330
Build 330: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
199 msPhabricatorProjectCoreTestCase::testAncestorMembers
EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
65 msPhabricatorProjectCoreTestCase::testJoinLeaveProject
EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
161 msPhabricatorProjectCoreTestCase::testMemberMaterialization
EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
104 msPhabricatorProjectCoreTestCase::testMilestoneMembership
EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
111 msPhabricatorProjectCoreTestCase::testParentProject
EXCEPTION (RuntimeException): Implicit conversion from float 76.50000000000001 to int loses precision #0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192) #1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)
View Full Test Results (7 Failed · 23 Passed)

Event Timeline

aklapper created this revision.May 1 2023, 23:01
Owners added a reviewer: O1: Blessed Committers.May 1 2023, 23:01
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 1 2023, 23:01
Harbormaster completed remote builds in B330: Diff 617.May 1 2023, 23:01
aklapper requested review of this revision.May 1 2023, 23:01
valerio.bozzolan mentioned this in T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ".May 3 2023, 10:16
valerio.bozzolan accepted this revision.May 3 2023, 10:24

Thanks for this patch again!

I tested the $name locally intensively with phlog() to verify that it assumes just null or native string.

The function phutil_nonempty_string() will report any other alien type, and that is OK.

(The errors in the unit tests are totally unrelated and this will be discussed in T15334)

✅ green light and thanks

sgtm

This revision is now accepted and ready to land.May 3 2023, 10:24
This revision was landed with ongoing or failed builds.May 3 2023, 10:50
Closed by commit rPb0cfb6ca6aca: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure…. · Explain Why
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPb0cfb6ca6aca: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure….

Revision Contents
Changeset List

PathSizePackages
src/
applications/
project/
menuitem/
2 linesO1: Blessed Committers

Diff 617

View Options

src/applications/project/menuitem/PhabricatorProjectDetailsProfileMenuItem.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0