Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page
ClosedPublic
Actions

Authored by aklapper on Apr 30 2023, 12:10.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15307: PHP 8.1 "strlen(null)" exceptions block rendering the Conduit page

Commits

rPd8d45d343ed4: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15307

Test Plan

Applied these two changes (on top D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153, D25154 locally applied) and /conduit/ finally
rendered in web browser. Also the page /conduit/query/.

Diff Detail

Repository

rP Phorge

Branch

D25156 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 304
Build 304: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 30 2023, 12:10

Owners added a reviewer: O1: Blessed Committers.Apr 30 2023, 12:10

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 30 2023, 12:10

aklapper requested review of this revision.Apr 30 2023, 12:10

Harbormaster completed remote builds in B304: Diff 570.Apr 30 2023, 12:10

valerio.bozzolan accepted this revision.Apr 30 2023, 12:35

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan added inline comments.

src/applications/conduit/query/PhabricatorConduitSearchEngine.php
42	✅ I logged the value of `$contains` in /conduit/query/ and its domain seems to be always NULL or a string. Alien values will be reported by `phutil_nonempty_string()` and that is OK.
src/view/phui/PHUIObjectItemView.php
877	✅ I logged the value of `$label` in 50+ pages and its domain seems to be always NULL or a string. Alien values will be reported by `phutil_nonempty_string()` and that is OK.