Page MenuHomePhorge
Differential D25075

Diviner: fix "Javascript" -> "JavaScript" and minor change
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 13 2023, 14:58.
Tags
None
Referenced Files
F2183854: D25075.id343.diff
Wed, May 8, 14:51
F2183853: D25075.id339.diff
Wed, May 8, 14:51
F2183852: D25075.id338.diff
Wed, May 8, 14:51
F2183766: D25075.id.diff
Wed, May 8, 13:58
F2183714: D25075.diff
Wed, May 8, 13:18
Unknown Object (File)
Tue, May 7, 07:48
Unknown Object (File)
Tue, May 7, 07:47
Unknown Object (File)
Mon, May 6, 07:08
View All Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
Tokens
"Love" token, awarded by valerio.bozzolan."Manufacturing Defect?" token, awarded by avivey.

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Commits
rP5cba56182f39: Diviner: fix "Javascript" -> "JavaScript" and minor change
Test Plan
  • look at Diviner and say "Java..."
  • Diviner will look at you saying "...Script"
  • you land, satisfied

If Diviner says "...script" instead (lowercase "S"), abandon the ship.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Mar 13 2023, 14:58
Owners added a reviewer: O1: Blessed Committers.Mar 13 2023, 14:58
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 13 2023, 14:58
valerio.bozzolan requested review of this revision.Mar 13 2023, 14:58
Harbormaster completed remote builds in B131: Diff 338.Mar 13 2023, 14:58
valerio.bozzolan updated this revision to Diff 339.Mar 13 2023, 14:59
  • fix linter
Harbormaster completed remote builds in B132: Diff 339.Mar 13 2023, 14:59
valerio.bozzolan added inline comments.Mar 13 2023, 15:00
src/docs/flavor/javascript_object_array.diviner
67

I added more minor examples there since it's not that obvious for people that o.stuff and o['stuff'] are the same.

87

I've added an "In short" paragraph since this topic deserved it.

valerio.bozzolan added inline comments.Mar 15 2023, 11:20
src/docs/flavor/javascript_object_array.diviner
63

I've added more examples here ↑ since being able to do both can be counter-intuitive

valerio.bozzolan mentioned this in Z1: Phorge.Mar 16 2023, 14:21
avivey accepted this revision.Mar 16 2023, 14:26
avivey awarded a token.
This revision is now accepted and ready to land.Mar 16 2023, 14:27
valerio.bozzolan awarded a token.Mar 16 2023, 14:27
Closed by commit rP5cba56182f39: Diviner: fix "Javascript" -> "JavaScript" and minor change. · Explain WhyMar 16 2023, 14:28
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP5cba56182f39: Diviner: fix "Javascript" -> "JavaScript" and minor change.

Revision Contents
Changeset List

Diff 343

View Options

src/docs/book/flavor.book

Loading...
View Options

src/docs/flavor/javascript_object_array.diviner

Loading...
View Options

src/docs/flavor/javascript_pitfalls.diviner

Loading...
View Options

src/docs/flavor/php_pitfalls.diviner

Loading...
View Options

src/docs/flavor/project_history.diviner

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0