Differential D25063

Show the API summary on the top of each Conduit API page
ClosedPublic
Actions

Authored by valerio.bozzolan on Feb 8 2023, 00:57.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15141: Show a summary on the top of each Conduit API page

Commits

rP36dba82224de: Show the API summary on the top of each Conduit API page

Summary

Show the API summary on the top of each Conduit API page.

Before this change, the summary was only displayed from the Conduit APIs list.

Closes T15141

Test Plan

I've opened 20 random Conduit API pages from the web
interface and I checked that now there is an amazing
"Summary" field.
I also double-checked that there were not green peppers.

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 106
Build 106: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	269 ms	PhabricatorLibraryTestCase::testLibraryMap Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.ManiphestSearchConduitAPIMethodSingle, xmap.ManiphestSearchConduitAPIMethodSingle.
	84 ms	PhabricatorCelerityTestCase::testCelerityMaps 1 assertion passed.
	10 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
	1 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed.
		View Full Test Results (1 Failed · 6 Passed)

Event Timeline

valerio.bozzolan created this revision.Feb 8 2023, 00:57

Owners added a reviewer: O1: Blessed Committers.Feb 8 2023, 00:57

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptFeb 8 2023, 00:57

valerio.bozzolan requested review of this revision.Feb 8 2023, 00:57

Harbormaster completed remote builds in B106: Diff 307.Feb 8 2023, 00:58

valerio.bozzolan retitled this revision from Show the API summary on the top of each Conduit API page Closes T15141 to Show the API summary on the top of each Conduit API page.Feb 8 2023, 01:00

valerio.bozzolan edited the summary of this revision. (Show Details)

valerio.bozzolan added a task: T15141: Show a summary on the top of each Conduit API page.

arc liberate

Harbormaster completed remote builds in B107: Diff 308.Feb 8 2023, 01:03

I don't think that it's the best UX improvement in the universe but at least it's an useful information that now it's visible somewhere

Render spoiler: