Remove unused keyboard shortcuts code
Needs ReviewPublic
Actions

Authored by aklapper on Fri, May 9, 10:57.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

PHUIPropertyListView defines setHasKeyboardShortcuts() using AphrontKeyboardShortcutsAvailableView setting the CSS class keyboard-shortcuts-available defined in phui-property-list-view.css and phui-property-list-view.css, the latter being the only consumer of the icon key_question.png.

Searching the codebase for asKeyboardShortcuts there are zero callers as src/applications/differential/view/DifferentialRevisionDetailView.php got deleted in https://we.phorge.it/rP148a50e48be146b88036032d1cad772d2627da28. Thus remove that unused code/files.

Note that this is unrelated to setEnableKeyboardShortcuts() in PHUIPagerView.

Test Plan

Grep the codebase for asKeyboardShortcuts

Diff Detail

Repository

rP Phorge

Branch

keyboardShortcuts (branched from master)

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1960
Build 1960: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	624 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:27): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	396 ms	PHUIInvisibleCharacterTestCase::testEmptyPlainText 1 assertion passed.
	391 ms	PHUIInvisibleCharacterTestCase::testEmptyString 1 assertion passed.
	419 ms	PHUIInvisibleCharacterTestCase::testHtmlDecoration 5 assertions passed.
	400 ms	PHUIInvisibleCharacterTestCase::testWithHexChars 1 assertion passed.
		View Full Test Results (1 Failed · 17 Passed)