Paths

Table of Contentst

Differential D25975

Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine()
ClosedPublic
Actions

Authored by aklapper on Sat, Apr 26, 20:34.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15891: Ineffective instanceof check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine()

Commits

rP35e233345cd6: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine()

Summary

Per PHPStan static code analysis, currently
Instanceof between PhabricatorSearchService and PhabricatorMySQLSearchHost will always evaluate to false.
Per discussion in the task and per testing, make the check work.

Closes T15891

Test Plan

Probably set up a Phorge instance with recent MariaDB/MySQL, and set up a Phorge instance with ancient DB versions (MySQL 5.6.3 or older; MariaDB 10.0 or older) not supporting FULLTEXT indexes for InnoDB tables?

Diff Detail

Repository

Branch

T15891 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1894
Build 1894: arc lint + arc unit

Event Timeline

aklapper created this revision.Sat, Apr 26, 20:34

Owners added a reviewer: O1: Blessed Committers.Sat, Apr 26, 20:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Apr 26, 20:34

aklapper requested review of this revision.Sat, Apr 26, 20:34

Harbormaster completed remote builds in B1894: Diff 2925.Sat, Apr 26, 20:34

20after4 accepted this revision.Sat, Apr 26, 22:53

This revision is now accepted and ready to land.Sat, Apr 26, 22:53

Closed by commit rP35e233345cd6: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine(). · Explain WhySun, Apr 27, 17:11

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP35e233345cd6: Fix check in PhabricatorMySQLSetupCheck:shouldUseMySQLSearchEngine().

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

config/

check/

PhabricatorMySQLSetupCheck.php

3 lines

1%

Loading...

O1: Blessed Committers

Diff 2925

src/applications/config/check/PhabricatorMySQLSetupCheck.php

Loading...