Reverts faulty git merge
ClosedPublic
Actions

Authored by bekay on Sat, Apr 12, 13:43.

Tags

None

Referenced Files

	F3748417: D25960.1745776882.diff
	Sat, Apr 26, 18:01

	F3686323: D25960.1745576083.diff
	Thu, Apr 24, 10:14

	F3685625: D25960.1745571504.diff
	Thu, Apr 24, 08:58

	F3681231: D25960.1745557182.diff
	Thu, Apr 24, 04:59

	F3680947: D25960.1745555983.diff
	Thu, Apr 24, 04:39

	F3676326: D25960.1745542704.diff
	Thu, Apr 24, 00:58

	F3675176: D25960.1745502220.diff
	Wed, Apr 23, 13:43

	F3605311: D25960.1745262475.diff
	Sun, Apr 20, 19:07

Subscribers

Details

Reviewers

mturdus

Commits

R5:451e5cf8aca0: Reverts faulty git merge

Summary

I have reintroduced removed code by landing R5:3170bc15592efd3b14a6e774f32da6b658ef27b7. The code in question was removed by R5:b1dde4993c81b07f6cbfe30dbaab3bd886c20075. I fix this git merge regression.

Test Plan

Just see how I can't do a proper merge and accept my fix.

Diff Detail

Repository

R5 Diagrams

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1863
Build 1863: arc lint + arc unit

Event Timeline

bekay created this revision.Sat, Apr 12, 13:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptSat, Apr 12, 13:43

bekay requested review of this revision.Sat, Apr 12, 13:43

Harbormaster completed remote builds in B1863: Diff 2867.Sat, Apr 12, 13:43

bekay mentioned this in D25612: Use more css and phorge standard elements for application view.Sat, Apr 12, 13:44

mturdus accepted this revision.Sun, Apr 13, 04:59

This revision is now accepted and ready to land.Sun, Apr 13, 04:59

Update

Harbormaster completed remote builds in B1865: Diff 2871.Sun, Apr 13, 09:12

Reset to original diff.

Closed by commit R5:451e5cf8aca0: Reverts faulty git merge. · Explain WhySun, Apr 13, 09:25

This revision was automatically updated to reflect the committed changes.

bekay added a commit: R5:451e5cf8aca0: Reverts faulty git merge.

Revision Contents
Changeset List

Path

Size

src/

controller/

DiagramController.php

11 lines

Diff 2867

View Options

src/controller/DiagramController.php

Reverts faulty git mergeClosedPublicActions