Page MenuHomePhorge

Replace usages of PhutilProxyException
ClosedPublic

Authored by mainframe98 on Wed, Apr 9, 18:20.

Details

Summary

This exception only exists for backwards compatibility with PHP versions
older than 5.3.0.
See https://www.php.net/manual/en/exception.getprevious.php and
https://we.phorge.it/rARC08432f5a24b3ead31c18623785daf5f985c8cfa5

Test Plan

Throw an exception with a nested exception and look at the error page.

Diff Detail

Repository
rP Phorge
Branch
T15904-replace-PhutilProxyException
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1854
Build 1854: arc lint + arc unit

Unit TestsFailed

TimeTest
310 msDiffusionCommandEngineTestCase::testCommandEngine
Assertion failed, expected values to be equal (at DiffusionCommandEngineTestCase.php:208). Expected vs Actual Output Diff --- Old Value
293 msAphrontIsolatedDatabaseConnectionTestCase::testDeletePermitted
1 assertion passed.
291 msAphrontIsolatedDatabaseConnectionTestCase::testInsertGeneratesID
3 assertions passed.
292 msAphrontIsolatedDatabaseConnectionTestCase::testIsolation
1 assertion passed.
297 msAphrontIsolatedDatabaseConnectionTestCase::testTransactionRollback
3 assertions passed.
View Full Test Results (1 Failed · 99 Passed)

Event Timeline

aklapper subscribed.

Thanks! Accepting per testing in D25956#25577

This revision is now accepted and ready to land.Mon, Apr 14, 07:14

Rebase and re-run tests with expected LANG