Differential D25957

Replace usages of PhutilProxyException
ClosedPublic
Actions

Authored by mainframe98 on Wed, Apr 9, 18:20.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15904: Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler

Commits

rPbf2dc1194778: Replace usages of PhutilProxyException

Summary

This exception only exists for backwards compatibility with PHP versions
older than 5.3.0.
See https://www.php.net/manual/en/exception.getprevious.php and
https://we.phorge.it/rARC08432f5a24b3ead31c18623785daf5f985c8cfa5

Test Plan

Throw an exception with a nested exception and look at the error page.

Diff Detail

Repository

rP Phorge

Branch

T15904-replace-PhutilProxyException

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1871
Build 1871: arc lint + arc unit

Event Timeline

mainframe98 created this revision.Wed, Apr 9, 18:20

Owners added a reviewer: O1: Blessed Committers.Wed, Apr 9, 18:20

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptWed, Apr 9, 18:20

mainframe98 requested review of this revision.Wed, Apr 9, 18:20

Harbormaster completed remote builds in B1854: Diff 2855.Wed, Apr 9, 18:20

aklapper edited the summary of this revision. (Show Details)Sat, Apr 12, 20:52

Thanks! Accepting per testing in D25956#25577

This revision is now accepted and ready to land.Mon, Apr 14, 07:14

aklapper edited the summary of this revision. (Show Details)Mon, Apr 14, 07:15

Rebase and re-run tests with expected LANG

Harbormaster completed remote builds in B1871: Diff 2883.Tue, Apr 15, 14:45

Closed by commit rPbf2dc1194778: Replace usages of PhutilProxyException. · Explain WhyTue, Apr 15, 14:46

This revision was automatically updated to reflect the committed changes.

mainframe98 added a commit: rPbf2dc1194778: Replace usages of PhutilProxyException.

aklapper mentioned this in Next Up.Tue, Apr 15, 15:04

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

resources/

sql/

autopatches/

20210215.changeset.02.phid-populate.php

3 lines

O1: Blessed Committers

20210802.legalpad_document_signature.02.phid-populate.php

3 lines

O1: Blessed Committers

src/

applications/

auth/

adapter/

PhutilAmazonAuthAdapter.php

3 lines

O1: Blessed Committers

PhutilDisqusAuthAdapter.php

3 lines

O1: Blessed Committers

PhutilFacebookAuthAdapter.php

3 lines

O1: Blessed Committers

PhutilGitHubAuthAdapter.php

3 lines

O1: Blessed Committers

PhutilGoogleAuthAdapter.php

3 lines

O1: Blessed Committers

future/

PhabricatorDuoFuture.php

3 lines

O1: Blessed Committers

sshkey/

PhabricatorAuthSSHPublicKey.php

3 lines

42%

O1: Blessed Committers

conduit/

controller/

PhabricatorConduitAPIController.php

3 lines

O1: Blessed Committers

ssh/

ConduitSSHWorkflow.php

3 lines

O1: Blessed Committers

differential/

__tests__/

DifferentialParseRenderTestCase.php

3 lines

89%

O1: Blessed Committers

diffusion/

protocol/

DiffusionRepositoryClusterEngine.php

6 lines

O1: Blessed Committers

doorkeeper/

bridge/

DoorkeeperBridge.php

3 lines

O1: Blessed Committers

drydock/

worker/

DrydockLeaseUpdateWorker.php

3 lines

O1: Blessed Committers

DrydockResourceUpdateWorker.php

3 lines

O1: Blessed Committers

DrydockWorker.php

4 lines

O1: Blessed Committers

files/

storage/

PhabricatorFile.php

3 lines

46%

O1: Blessed Committers

herald/

controller/

HeraldRuleController.php

3 lines

O1: Blessed Committers

metamta/

adapter/

PhabricatorMailMailgunAdapter.php

3 lines

O1: Blessed Committers

future/

PhabricatorTwilioFuture.php

3 lines

O1: Blessed Committers

nuance/

github/

__tests__/

NuanceGitHubRawEventTestCase.php

3 lines

77%

O1: Blessed Committers

policy/

controller/

PhabricatorPolicyEditController.php

3 lines

O1: Blessed Committers

repository/

daemon/

PhabricatorRepositoryPullLocalDaemon.php

3 lines

O1: Blessed Committers

management/

PhabricatorRepositoryManagementUpdateWorkflow.php

3 lines

O1: Blessed Committers

search/

fulltextstorage/

PhabricatorElasticFulltextStorageEngine.php

3 lines

O1: Blessed Committers

transactions/

editengine/

PhabricatorEditEngine.php

3 lines

O1: Blessed Committers

xhprof/

controller/

PhabricatorXHProfProfileController.php

3 lines

O1: Blessed Committers

infrastructure/

daemon/

workers/

PhabricatorTaskmasterDaemon.php

6 lines

O1: Blessed Committers

PhabricatorTriggerDaemon.php

3 lines

O1: Blessed Committers

PhabricatorWorker.php

3 lines

33%

O1: Blessed Committers

env/

PhabricatorConfigLocalSource.php

6 lines

O1: Blessed Committers

storage/

lisk/

LiskDAO.php

3 lines

75%

O1: Blessed Committers

PhabricatorLiskDAO.php

3 lines

50%

O1: Blessed Committers

management/

PhabricatorStorageManagementAPI.php

6 lines

O1: Blessed Committers

Diff 2883

View Options

resources/sql/autopatches/20210215.changeset.02.phid-populate.php

View Options

resources/sql/autopatches/20210802.legalpad_document_signature.02.phid-populate.php

View Options

src/applications/auth/adapter/PhutilAmazonAuthAdapter.php

View Options

src/applications/auth/adapter/PhutilDisqusAuthAdapter.php

View Options

src/applications/auth/adapter/PhutilFacebookAuthAdapter.php

View Options

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

View Options

src/applications/auth/adapter/PhutilGoogleAuthAdapter.php

View Options

src/applications/auth/future/PhabricatorDuoFuture.php

View Options

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

View Options

src/applications/conduit/ssh/ConduitSSHWorkflow.php

View Options

src/applications/differential/tests/DifferentialParseRenderTestCase.php

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

View Options

src/applications/doorkeeper/bridge/DoorkeeperBridge.php

View Options

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

View Options

src/applications/drydock/worker/DrydockResourceUpdateWorker.php

View Options

src/applications/drydock/worker/DrydockWorker.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/herald/controller/HeraldRuleController.php

View Options

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php

View Options

src/applications/metamta/future/PhabricatorTwilioFuture.php

View Options

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php

View Options

src/applications/policy/controller/PhabricatorPolicyEditController.php

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

View Options

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

View Options

src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/xhprof/controller/PhabricatorXHProfProfileController.php

View Options

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

View Options

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

View Options

src/infrastructure/env/PhabricatorConfigLocalSource.php

View Options

src/infrastructure/storage/lisk/LiskDAO.php

View Options

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Replace usages of PhutilProxyExceptionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2883

resources/sql/autopatches/20210215.changeset.02.phid-populate.php

resources/sql/autopatches/20210802.legalpad_document_signature.02.phid-populate.php

src/applications/auth/adapter/PhutilAmazonAuthAdapter.php

src/applications/auth/adapter/PhutilDisqusAuthAdapter.php

src/applications/auth/adapter/PhutilFacebookAuthAdapter.php

src/applications/auth/adapter/PhutilGitHubAuthAdapter.php

src/applications/auth/adapter/PhutilGoogleAuthAdapter.php

src/applications/auth/future/PhabricatorDuoFuture.php

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

src/applications/conduit/controller/PhabricatorConduitAPIController.php

src/applications/conduit/ssh/ConduitSSHWorkflow.php

src/applications/differential/__tests__/DifferentialParseRenderTestCase.php

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

src/applications/doorkeeper/bridge/DoorkeeperBridge.php

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

src/applications/drydock/worker/DrydockResourceUpdateWorker.php

src/applications/drydock/worker/DrydockWorker.php

src/applications/files/storage/PhabricatorFile.php

src/applications/herald/controller/HeraldRuleController.php

src/applications/metamta/adapter/PhabricatorMailMailgunAdapter.php

src/applications/metamta/future/PhabricatorTwilioFuture.php

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

src/applications/policy/controller/PhabricatorPolicyEditController.php

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php

src/applications/transactions/editengine/PhabricatorEditEngine.php

src/applications/xhprof/controller/PhabricatorXHProfProfileController.php

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

src/infrastructure/daemon/workers/PhabricatorTriggerDaemon.php

src/infrastructure/daemon/workers/PhabricatorWorker.php

src/infrastructure/env/PhabricatorConfigLocalSource.php

src/infrastructure/storage/lisk/LiskDAO.php

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Replace usages of PhutilProxyException
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/differential/tests/DifferentialParseRenderTestCase.php

src/applications/nuance/github/tests/NuanceGitHubRawEventTestCase.php