Uploaded an example email with a lot of accents called 'test_accents.mbox' and
expected headers in the file 'test_accents.headers.txt'.
Better than nothing.
This change also includes a minor refactor in the library loading.
Ref T15960
Details
Details
- Reviewers
aklapper taavi - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them
- Commits
- rP9d3e25885335: Add first unit test for mimemailparser headers
Manually run the new unit test and see green lights:
arc unit src/applications/metamta/externals/__tests__/PhabricatorExternalMimeMailParserTestCase.php
Double-check that the new class is already recorded:
arc liberate
Just as extra care, re-apply the same test plan of:
So, for example, run this, and see no exceptions:
./scripts/mail/mail_handler.php < src/applications/metamta/externals/__tests__/data/test_accents.mbox
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- unit-test-asd
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1638 Build 1638: arc lint + arc unit
Event Timeline
Comment Actions
lol @taavi I've stolen some of your "ä" for the example file test_accents.mbox, I hope you won't send me a lawyer
Comment Actions
Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)
I also tested by feeding some emails from my collection of broken test emails (it's sometimes useful to be a GNOME Evolution docs maintainer) into ./scripts/mail/mail_handler.php after editing mail_handler.php to also include print $headers['from']; print "\n"; print $headers['subject']; print "\n";
| src/applications/metamta/externals/__tests__/data/test_accents.mbox | ||
|---|---|---|
| 26 | Thanks for the question. This phrase in Italian means:
| |