Add first unit test for mimemailparser headers
ClosedPublic
Actions

Authored by valerio.bozzolan on Tue, Dec 3, 15:44.

Details

Reviewers

aklapper
taavi

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15960: Incoming mail parsing fails if specific headers have UTF-8 encoded text in them

Commits

rP9d3e25885335: Add first unit test for mimemailparser headers

Summary

Uploaded an example email with a lot of accents called 'test_accents.mbox' and
expected headers in the file 'test_accents.headers.txt'.

Better than nothing.

This change also includes a minor refactor in the library loading.

Ref T15960

Test Plan

Manually run the new unit test and see green lights:

arc unit src/applications/metamta/externals/__tests__/PhabricatorExternalMimeMailParserTestCase.php

Double-check that the new class is already recorded:

arc liberate

Just as extra care, re-apply the same test plan of:

D25839

So, for example, run this, and see no exceptions:

./scripts/mail/mail_handler.php < src/applications/metamta/externals/__tests__/data/test_accents.mbox

Diff Detail

Repository

rP Phorge

Branch

unit-test-asd

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1638
Build 1638: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Tue, Dec 3, 15:44

Owners added a reviewer: O1: Blessed Committers.Tue, Dec 3, 15:44

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptTue, Dec 3, 15:44

valerio.bozzolan requested review of this revision.Tue, Dec 3, 15:44

Harbormaster completed remote builds in B1638: Diff 2551.Tue, Dec 3, 15:44

lol @taavi I've stolen some of your "ä" for the example file test_accents.mbox, I hope you won't send me a lawyer

git rebase origin/master

Harbormaster completed remote builds in B1639: Diff 2552.Tue, Dec 3, 15:52

valerio.bozzolan edited the test plan for this revision. (Show Details)Tue, Dec 3, 15:53

In D25844#22553, @valerio.bozzolan wrote:

I hope you won't send me a lawyer

do you really think I could afford one

aklapper edited the test plan for this revision. (Show Details)Tue, Dec 3, 21:20

Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)

I also tested by feeding some emails from my collection of broken test emails (it's sometimes useful to be a GNOME Evolution docs maintainer) into ./scripts/mail/mail_handler.php after editing mail_handler.php to also include print $headers['from']; print "\n"; print $headers['subject']; print "\n";

This revision is now accepted and ready to land.Tue, Dec 3, 22:24

valerio.bozzolan added inline comments.Wed, Dec 4, 07:49