Page MenuHomePhorge
Differential D25841

Account registration: Restrict Real Name length
ClosedPublic
Actions

Authored by aklapper on Fri, Nov 29, 14:22.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15962: Account registration: Handle too long Real Name more gracefully
Commits
rPeb380f922c9a: Account registration: Restrict Real Name length
Summary

Avoid a database exception at user account registration when users enter very long real names by setting a maximum length.
This does not affect existing account data as it is only called in the account registration code.

Fixes T15962

Test Plan

Go to http://phorge.localhost/auth/register/ and enter long values into the "Real Name" field

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Fri, Nov 29, 14:22
Owners added a reviewer: O1: Blessed Committers.Fri, Nov 29, 14:22
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Nov 29, 14:22
aklapper requested review of this revision.Fri, Nov 29, 14:22
Harbormaster completed remote builds in B1632: Diff 2542.Fri, Nov 29, 14:22
• l2dy subscribed.Fri, Nov 29, 14:29
• l2dy added inline comments.
src/applications/people/storage/PhabricatorUser.php
557

In function describeValidUsername(), the number is wrapped in new PhutilNumber(). Should they be consistent?

aklapper edited the summary of this revision. (Show Details)Fri, Nov 29, 14:30
aklapper updated this revision to Diff 2543.Fri, Nov 29, 14:33

Thanks for catching that! Amend in new PhutilNumber()

Harbormaster completed remote builds in B1633: Diff 2543.Fri, Nov 29, 14:33
aklapper marked an inline comment as done.Fri, Nov 29, 14:33
valerio.bozzolan accepted this revision.Fri, Nov 29, 18:11

sgtm. Thanks :) just that comment

src/applications/people/storage/PhabricatorUser.php
561

We can just return the result of strlen() <= that

Thanks :)

This revision is now accepted and ready to land.Fri, Nov 29, 18:11
aklapper updated this revision to Diff 2544.Sat, Nov 30, 12:17

Simplify return of validateRealName() as proposed by Valerio

Harbormaster completed remote builds in B1634: Diff 2544.Sat, Nov 30, 12:17
valerio.bozzolan accepted this revision.Sat, Nov 30, 13:01

Double slam accept

aklapper marked an inline comment as done.Mon, Dec 2, 19:36
Closed by commit rPeb380f922c9a: Account registration: Restrict Real Name length. · Explain WhyMon, Dec 2, 19:36
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPeb380f922c9a: Account registration: Restrict Real Name length.
valerio.bozzolan mentioned this in Next Up.Tue, Dec 10, 14:03

Revision Contents
Changeset List

PathSizePackages
src/
applications/
auth/
controller/
4 linesO1: Blessed Committers
people/
storage/
11 linesO1: Blessed Committers

Diff 2548

View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0