Avoid a database exception at user account registration when users enter very long real names by setting a maximum length.
This does not affect existing account data as it is only called in the account registration code.
Fixes T15962
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15962: Account registration: Handle too long Real Name more gracefully
- Commits
- rPeb380f922c9a: Account registration: Restrict Real Name length
Go to http://phorge.localhost/auth/register/ and enter long values into the "Real Name" field
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15962 (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1633 Build 1633: arc lint + arc unit
Event Timeline
| src/applications/people/storage/PhabricatorUser.php | ||
|---|---|---|
| 557 | In function describeValidUsername(), the number is wrapped in new PhutilNumber(). Should they be consistent? | |
Comment Actions
sgtm. Thanks :) just that comment
| src/applications/people/storage/PhabricatorUser.php | ||
|---|---|---|
| 561 | We can just return the result of strlen() <= that Thanks :) | |