Differential D25831

Fix implicitly nullable parameter declarations for PHP 8.4
ClosedPublic
Actions

Authored by aklapper on Oct 23 2024, 09:57.

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Commits

rARC29ca3df1122b: Fix implicitly nullable parameter declarations for PHP 8.4

Summary

Followup to rARC99e57a70. This patch should cover all remaining issues now that PHPStan covers it (instead of the previous trial-and-error approach).

Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1 and Phorge requires PHP 7.2 now.

Test Plan

Run static code analysis.

Diff Detail

Repository

Branch

nullable84rest

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 1610
Build 1610: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	687 ms	ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'. #0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(87): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture)) #1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): ArcanistBundleTestCase->testGitRepository()
	83 ms	ArcanistBaseCommitParserTestCase::testBasics 2 assertion(s) passed.
	83 ms	ArcanistBaseCommitParserTestCase::testHalt 1 assertion(s) passed.
	76 ms	ArcanistBaseCommitParserTestCase::testJump 1 assertion(s) passed.
	93 ms	ArcanistBaseCommitParserTestCase::testJumpReturn 1 assertion(s) passed.
		View Full Test Results (1 Failed · 85 Passed)

Event Timeline

aklapper created this revision.Oct 23 2024, 09:57

Owners added a reviewer: O1: Blessed Committers.Oct 23 2024, 09:57

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 23 2024, 09:57

aklapper requested review of this revision.Oct 23 2024, 09:57

Harbormaster completed remote builds in B1610: Diff 2505.Oct 23 2024, 09:57

aklapper mentioned this in Z1: Phorge.Oct 24 2024, 09:35

avivey accepted this revision.Oct 24 2024, 09:55

This revision is now accepted and ready to land.Oct 24 2024, 09:55

This revision was landed with ongoing or failed builds.Oct 24 2024, 15:16

Closed by commit rARC29ca3df1122b: Fix implicitly nullable parameter declarations for PHP 8.4. · Explain Why

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC29ca3df1122b: Fix implicitly nullable parameter declarations for PHP 8.4.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

future/

FutureProxy.php

2 lines

0%

Loading...

O1: Blessed Committers

parser/

aast/

api/

6 lines

0%

Loading...

O1: Blessed Committers

repository/

marker/

ArcanistMarkerRef.php

2 lines

3%

Loading...

O1: Blessed Committers

ArcanistMercurialRepositoryMarkerQuery.php

4 lines

3%

Loading...

O1: Blessed Committers

unit/

ArcanistUnitTestResult.php

2 lines

43%

Loading...

O1: Blessed Committers

engine/

ArcanistUnitTestEngine.php

2 lines

25%

Loading...

O1: Blessed Committers

Diff 2505

src/future/FutureProxy.php

Loading...

src/parser/aast/api/AASTNode.php

Loading...

src/repository/marker/ArcanistMarkerRef.php

Loading...

src/repository/marker/ArcanistMercurialRepositoryMarkerQuery.php

Loading...

src/unit/ArcanistUnitTestResult.php

Loading...

src/unit/engine/ArcanistUnitTestEngine.php

Loading...