Update mimemailparser from May 2011 version to 8.0.4
ClosedPublic
Actions

Authored by aklapper on Oct 20 2024, 17:22.

Details

Reviewers

20after4

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15940: Update copy of external mimemailparser library

Commits

rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4

Summary

Bump to version 8.0.4 from 2024-09-11 per https://github.com/php-mime-mail-parser/php-mime-mail-parser/releases before this ancient code copy falls apart.
scripts/mail/mail_handler.php (used for incoming (!) mail) is the only consumer.

Closes T15940

Test Plan

Feed mail_handler.php with various test emails (formats: plain text, HTML, multipart; encodings: UTF-8, ASCII, ISO-8859-something) by manually replacing php://stdin with corresponding text files and adding some phlogs for output checking as I don't have mail server glue handy. Get only expected errors for broken emails.

Diff Detail

Repository

rP Phorge

Branch

mimemailparser804

Lint

Lint Errors

Severity	Location	Code	Message
Error	scripts/mail/mail_handler.php:43	XHP1	PHP Syntax Error!

Unit

No Test Coverage

Build Status

Buildable 1608
Build 1608: arc lint + arc unit

Event Timeline

aklapper created this revision.Oct 20 2024, 17:22

Owners added a reviewer: O1: Blessed Committers.Oct 20 2024, 17:22

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 20 2024, 17:22

aklapper requested review of this revision.Oct 20 2024, 17:22

Harbormaster completed remote builds in B1605: Diff 2495.Oct 20 2024, 17:22

aklapper mentioned this in T15766: Cleanup a bit MimeMailParser.Oct 20 2024, 17:26

It would be nice to have some unit tests for this but that seems like it might be quite a bit of work to implement.

If I can find some time to work on it then I will take a stab at creating tests in a follow-up.

This revision is now accepted and ready to land.Oct 20 2024, 20:37

mimemailparser: Check that PHP mailparse extension is installed

Harbormaster completed remote builds in B1608: Diff 2500.Oct 22 2024, 11:50

Fix typo

Harbormaster completed remote builds in B1609: Diff 2501.Oct 22 2024, 11:51

For testing, I deployed the latest revision of this proposed patch in our downstream instance and created a task via incoming plain text mail with attachments - seems to still work as expected so no obvious breakage (yet): https://phabricator.wikimedia.org/T377859

This very patch got deployed on our rather active downstream instance 10 days ago. I have not heard complaints and I've seen tasks and task comments (replies) created via email, so I'm now pretty confident that it does what it should. Thus I'm going to merge it to reduce technical debt a bit more in Phorge.

Closed by commit rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4. · Explain WhyNov 1 2024, 07:59

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPa76444a8e238: Update mimemailparser from May 2011 version to 8.0.4.

aklapper mentioned this in Next Up.Nov 1 2024, 08:00