Differential D25827

Allow zooming on pages
ClosedPublic
Actions

Authored by aklapper on Oct 2 2024, 12:44.

Details

Reviewers

20after4

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15945: Allow zooming Phorge pages on mobile

Commits

rP828ea9bca030: Allow zooming on pages

Summary

Zooming on pages is currently disabled for reasons mentioned in rP953ab039acc0894e287304364920bc7cc4962cc0 from 2017.
This violates WCAG and is especially unhelpful on a mobile phone to see a larger version of an image file.
Thus allow zooming, crossing fingers that mobile platforms have reduced the unwanted side effects over the last seven years.

Closes T15945

Test Plan

Use Firefox on an Android phone in portrait orientation; Visit a Phorge task which has an image embedded; Click on the image comment; Pinch with fingers to zoom.

Diff Detail

Repository

rP Phorge

Branch

zoomT15945

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1603
Build 1603: arc lint + arc unit

Event Timeline

aklapper created this revision.Oct 2 2024, 12:44

Owners added a reviewer: O1: Blessed Committers.Oct 2 2024, 12:44

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 2 2024, 12:44

aklapper requested review of this revision.Oct 2 2024, 12:44

Harbormaster completed remote builds in B1603: Diff 2490.Oct 2 2024, 12:44

aklapper edited the summary of this revision. (Show Details)Oct 2 2024, 12:45

This one seems worthy of a rubber stamp. And a gold star.

This revision is now accepted and ready to land.Oct 9 2024, 08:05

20after4 awarded a token.Oct 9 2024, 08:06

P.S. maybe relevant - maybe not :D lol https://we.phorge.it/T15945#19568

Closed by commit rP828ea9bca030: Allow zooming on pages. · Explain WhyNov 26 2024, 13:07

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP828ea9bca030: Allow zooming on pages.

aklapper mentioned this in Next Up.Nov 26 2024, 13:12

avivey mentioned this in 2025.18.Fri, May 2, 11:35

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

view/

page/

PhabricatorBarePageView.php

2 lines

O1: Blessed Committers

Diff 2490

View Options

src/view/page/PhabricatorBarePageView.php

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines	private function executeParserTest($name, $file) {

$future = PhutilXHPASTBinary::getParserFuture($data);		$future = PhutilXHPASTBinary::getParserFuture($data);
list($err, $stdout, $stderr) = $future->resolve();		list($err, $stdout, $stderr) = $future->resolve();

switch ($type) {		switch ($type) {
case 'pass':		case 'pass':
$this->assertEqual(0, $err, pht('Exit code for "%s".', $name));		$this->assertEqual(0, $err, pht('Exit code for "%s".', $name));

if (!strlen($expect)) {		if (!phutil_nonempty_string($expect)) {
// If there's no "expect" data in the test case, that's OK.		// If there's no "expect" data in the test case, that's OK.
break;		break;
}		}

try {		try {
$stdout = phutil_json_decode($stdout);		$stdout = phutil_json_decode($stdout);
} catch (PhutilJSONParserException $ex) {		} catch (PhutilJSONParserException $ex) {
throw new PhutilProxyException(		throw new PhutilProxyException(
▲ Show 20 Lines • Show All 237 Lines • Show Last 20 Lines

Allow zooming on pagesClosedPublicActions