Paths

Table of Contentst

Differential D25800

Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
ClosedPublic
Actions

Authored by aklapper on Fri, Aug 23, 11:08.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15926: PHP 8.1 "strlen(null)"/preg_match() exceptions running unit tests

Commits

rARCf9749273778b: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]

Test Plan

Either read the code, or probably run something like arc unit on D25797?

Diff Detail

Repository

Branch

strlenPHPASTParserTestCase

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1559
Build 1559: arc lint + arc unit

Event Timeline

aklapper created this revision.Fri, Aug 23, 11:08

Owners added a reviewer: O1: Blessed Committers.Fri, Aug 23, 11:08

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Aug 23, 11:08

aklapper requested review of this revision.Fri, Aug 23, 11:08

Harbormaster completed remote builds in B1559: Diff 2415.Fri, Aug 23, 11:08

aklapper mentioned this in D25809: ArcanistBundleTestCase: fix support of non-English environments.Mon, Aug 26, 21:41

sgtm

This revision is now accepted and ready to land.Tue, Sep 3, 05:13

Closed by commit rARCf9749273778b: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase. · Explain WhyTue, Sep 3, 10:08

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARCf9749273778b: Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

parser/

xhpast/

__tests__/

PHPASTParserTestCase.php

2 lines

84%

Loading...

O1: Blessed Committers

Diff 2415

src/parser/xhpast/tests/PHPASTParserTestCase.php

Loading...