Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception in PHPASTParserTestCase
ClosedPublic

Authored by aklapper on Aug 23 2024, 11:08.
Tags
None
Referenced Files
F3318341: D25800.1743280600.diff
Fri, Mar 28, 20:36
F3311234: D25800.1743202471.diff
Thu, Mar 27, 22:54
F3307931: D25800.1743154510.diff
Thu, Mar 27, 09:35
F3307930: D25800.1743154509.diff
Thu, Mar 27, 09:35
F3307929: D25800.1743154505.diff
Thu, Mar 27, 09:35
F3307918: D25800.1743154132.diff
Thu, Mar 27, 09:28
F3304354: D25800.1743097072.diff
Wed, Mar 26, 17:37
F3300070: D25800.1743033116.diff
Tue, Mar 25, 23:51

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/arcanist/src/parser/xhpast/__tests__/PHPASTParserTestCase.php:85]

Refs T15926

Test Plan

Either read the code, or probably run something like arc unit on D25797?

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable